Re: [PATCH net-next v9 03/11] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] build: module rename from oa_tc6.ko to oa_tc6_mod.ko breaks userspace ABI
- [Low] build: incorrect use of immediate assignment := for obj- variables
--

commit 0bfed8040741146a241b85eae9b49a4eb898b379
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

This commit moves the existing oa_tc6.c file to a dedicated oa_tc6
subdirectory under drivers/net/ethernet. It updates the Kconfig and Makefile
structures to accommodate this new location. The change is intended to
prepare for adding more files related to hardware timestamps and PTP APIs.

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Makefile b/drivers/net/ethernet/oa_tc6/Makefile
> new file mode 100644
> index 0000000000000..f24aae852ef27
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Makefile for OA TC6 10BASE-T1x MAC-PHY
> +#
> +
> +obj-$(CONFIG_OA_TC6) := oa_tc6_mod.o

[Severity: Low]
Is it correct to use the immediate assignment operator := here?

Using := instead of the standard Kbuild append operator += for obj- variables
clobbers any prior assignments. While this currently works because there are
no other entries in this new subdirectory Makefile, it breaks Kbuild
composability.

> +oa_tc6_mod-objs := oa_tc6.o

[Severity: Medium]
Does this break userspace ABI by renaming the resulting kernel module?

The patch changes the target object name from oa_tc6.o to oa_tc6_mod.o,
causing the resulting kernel module to be named oa_tc6_mod.ko instead of
oa_tc6.ko.

Module names are part of the kernel's userspace ABI. Renaming an existing
kernel module breaks userspace configurations that explicitly reference the
old name, such as initramfs scripts, modprobe configurations
(/etc/modprobe.d/), and autoload lists (/etc/modules-load.d/).

To preserve the module name while supporting multiple source files, the
original oa_tc6.c could be renamed (e.g., to oa_tc6_core.c or oa_tc6_main.c)
and the Makefile could use obj-$(CONFIG_OA_TC6) += oa_tc6.o alongside
oa_tc6-y := oa_tc6_core.o.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-s2500-mac-phy-support-v9-0-dcefe1d0bf0d@onsemi.com?part=3