[PATCH 00/14] ARM: dts: imx: cleanup some CHECK_DTBS warnings

[PATCH 00/14] ARM: dts: imx: cleanup some CHECK_DTBS warnings

[Frank.Li]

cleanup more CHECK_DTBS warnings.
less than 90 line warns left, from 267 line.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (14):
      ARM: dts: imx6q-dms-ba16: remove undocumented property fsl,receive-dpll-mode
      ARM: dts: imx50-amazon-yoshi: remove undocument property min-frequency
      ARM: dts: imx6dl-b155v2: add touchscreen size properties
      ARM: dts: imx6q-gw5400-a: fix SPI NOR flash vendor prefix
      ARM: dts: imx6dl-prtmvt: remove redundant panel compatible fallback
      ARM: dts: imx53-smd: change compatible string to dlg,da9053-aa
      ARM: dts: imx6qdl-savageboard: remove undocument avic,tm097tdh02
      ARM: dts: imx6qdl-apalis: remove disabled node "panel-lvds"
      ARM: dts: imx6ul-tx6ul: remove front compatible string karo,imx6ul-tx6ul-sgtl5000
      ARM: dts: imx6qdl-tx6-mb7: remove redundant pixelclk-active for simple panel
      ARM: dts: imx6q-h100: rename port to port@0 for mipi_csi
      ARM: dts: imx6qdl-sabrelite: fix typo vync-active
      ARM: dts: imx6q-novena: use interrupts replace irq-gpio
      ARM: dts: imx6sx-sdb-mqs: remove empty pinctrl-0

 arch/arm/boot/dts/nxp/imx/imx50-amazon-yoshi.dts   |  1 -
 arch/arm/boot/dts/nxp/imx/imx53-smd.dts            |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts        |  2 ++
 arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts        |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts       |  1 -
 arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts       |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6q-h100.dts           |  4 +++-
 arch/arm/boot/dts/nxp/imx/imx6q-novena.dts         |  3 ++-
 arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi      | 16 ----------------
 arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi   |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6qdl-savageboard.dtsi |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi     |  3 ---
 arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts       |  1 -
 arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi        |  3 +--
 14 files changed, 13 insertions(+), 31 deletions(-)
---
base-commit: 24a13508d0bbe0120c15212a3bcdfceef1941a6c
change-id: 20261016-arm_dts_cleanup2-efd86a2fa52d

Best regards,
--  
Frank Li <Frank.Li@nxp.com>

[PATCH 01/14] ARM: dts: imx6q-dms-ba16: remove undocumented property fsl,receive-dpll-mode

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

fsl,receive-dpll-mode is never documented and used in kernel tree. And also
not used by known user, such as uboot.

Remove it to fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dtb: sata@2200000 (fsl,imx6q-ahci): 'fsl,receive-dpll-mode' does not match any of the regexes: '^pinctrl-[0-9]+$'
        from schema $id: http://devicetree.org/schemas/ata/imx-sata.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts b/arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts
index 484a60892229d..766cd50390bc0 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts
@@ -115,7 +115,6 @@ &sata {
 	fsl,transmit-atten-16ths = <12>;
 	fsl,transmit-boost-mdB = <3330>;
 	fsl,transmit-level-mV = <1133>;
-	fsl,receive-dpll-mode = <1>;
 	status = "okay";
 };
 

-- 
2.43.0

[PATCH 02/14] ARM: dts: imx50-amazon-yoshi: remove undocument property min-frequency

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Remove undocumented and unused property min-frequency, which also not used
by known other user, such as uboot.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx50-amazon-yoshi.dtb: mmc@50020000 (fsl,imx50-esdhc): Unevaluated properties are not allowed ('min-frequency' was unexpected)
        from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx50-amazon-yoshi.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx50-amazon-yoshi.dts b/arch/arm/boot/dts/nxp/imx/imx50-amazon-yoshi.dts
index 417972ad6bb3e..0b6d0ba65f957 100644
--- a/arch/arm/boot/dts/nxp/imx/imx50-amazon-yoshi.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx50-amazon-yoshi.dts
@@ -21,7 +21,6 @@ &esdhc3 {
 	pinctrl-0 = <&pinctrl_sd3>;
 	bus-width = <8>;
 	non-removable;
-	min-frequency = <400000>;
 	max-frequency = <40000000>;
 	disable-wp;
 	status = "okay";

-- 
2.43.0

[PATCH 03/14] ARM: dts: imx6dl-b155v2: add touchscreen size properties

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

The eeti,exc3000 schema requires touchscreen-size-x and touchscreen-size-y
properties. Add them for the EXC80H84 touchscreen on the B155v2 board,
matching the 1366x768 resolution of the AUO G156XTN01 panel.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dtb: touchscreen@2a (eeti,exc80h84): 'touchscreen-size-x' is a required property
        from schema $id: http://devicetree.org/schemas/input/touchscreen/eeti,exc3000.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
index 7edc788bcb8f3..54db44613df66 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
@@ -25,6 +25,8 @@ touchscreen@2a {
 		pinctrl-0 = <&pinctrl_q7_gpio0>;
 		interrupt-parent = <&gpio5>;
 		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+		touchscreen-size-x = <1366>;
+		touchscreen-size-y = <768>;
 		touchscreen-inverted-x;
 		touchscreen-inverted-y;
 		reset-gpios = <&tca6424a 21 GPIO_ACTIVE_HIGH>;

-- 
2.43.0

[PATCH 04/14] ARM: dts: imx6q-gw5400-a: fix SPI NOR flash vendor prefix

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

The W25Q256 is a Winbond part. Replace the incorrect 'sst,w25q256'
compatible string with 'winbond,w25q256' to match the jedec,spi-nor
schema, which accepts '(winbond,)?w25q256' but not 'sst,w25q256'.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dtb: flash@0 (sst,w25q256): compatible: 'oneOf' conditional failed, one must be fixed:
        ['sst,w25q256', 'jedec,spi-nor'] is too long

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts b/arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts
index bf8fde9cb38d9..89c52b2e7c24f 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts
@@ -128,7 +128,7 @@ &ecspi1 {
 	status = "okay";
 
 	flash: flash@0 {
-		compatible = "sst,w25q256", "jedec,spi-nor";
+		compatible = "winbond,w25q256", "jedec,spi-nor";
 		spi-max-frequency = <30000000>;
 		reg = <0>;
 	};

-- 
2.43.0

[PATCH 05/14] ARM: dts: imx6dl-prtmvt: remove redundant panel compatible fallback

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

The panel-simple schema allows only a single compatible string. Drop the
spurious 'lg,lb070wv8' fallback from the kyo,tcg070wvlq panel node.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dtb: panel (kyo,tcg070wvlq): compatible: ['kyo,tcg070wvlq', 'lg,lb070wv8'] is too long
        from schema $id: http://devicetree.org/schemas/display/panel/panel-simple.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts
index dcd5a4099c602..4896cd3deaa98 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts
@@ -178,7 +178,7 @@ led-2 {
 	};
 
 	panel {
-		compatible = "kyo,tcg070wvlq", "lg,lb070wv8";
+		compatible = "kyo,tcg070wvlq";
 		backlight = <&backlight>;
 		power-supply = <&reg_3v3>;
 

-- 
2.43.0

[PATCH 06/14] ARM: dts: imx53-smd: change compatible string to dlg,da9053-aa

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

All imx53-smd use the same PMIC with imx53-qsb boards. It should be
dlg,da9053-aa. dlg,da9053 is not supported by drivers and wrong fallback
to dlg,da9052.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: dialog@48 (dlg,da9053): compatible: ['dlg,da9053', 'dlg,da9052'] is too long
        from schema $id: http://devicetree.org/schemas/trivial-devices.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx53-smd.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx53-smd.dts b/arch/arm/boot/dts/nxp/imx/imx53-smd.dts
index 29d38484cd386..aed551566683c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-smd.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx53-smd.dts
@@ -323,7 +323,7 @@ ov5642_to_ipu_csi0: endpoint {
 	};
 
 	pmic: dialog@48 {
-		compatible = "dlg,da9053", "dlg,da9052";
+		compatible = "dlg,da9053-aa";
 		reg = <0x48>;
 		interrupt-parent = <&gpio7>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

-- 
2.43.0

[PATCH 07/14] ARM: dts: imx6qdl-savageboard: remove undocument avic,tm097tdh02

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Remove undocument avic,tm097tdh02 compatible string, which is not supported
by simple-panel driver. Use fallback compatible string hannstar,hsd100pxn1.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6dl-savageboard.dtb: panel (avic,tm097tdh02): compatible: ['avic,tm097tdh02', 'hannstar,hsd100pxn1'] is too long
        from schema $id: http://devicetree.org/schemas/display/panel/panel-simple.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-savageboard.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-savageboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-savageboard.dtsi
index 2daf2b6af8849..8b476b39aaaf3 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-savageboard.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-savageboard.dtsi
@@ -67,7 +67,7 @@ key-power {
 	};
 
 	panel {
-		compatible = "avic,tm097tdh02", "hannstar,hsd100pxn1";
+		compatible = "hannstar,hsd100pxn1";
 		backlight = <&panel_bl>;
 		power-supply = <&reg_3p3v>;
 

-- 
2.43.0

[PATCH 08/14] ARM: dts: imx6qdl-apalis: remove disabled node "panel-lvds"

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

"panel-lvds"'s status is disabled and no dtso overlay to enable it. So
remove it to fix below CHECK_DTBS:
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtb: panel-lvds (panel-lvds): compatible: ['panel-lvds'] is too short
        from schema $id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml

Reduce move than 44 lines warnings.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
index af038ac472261..3f6a77453516e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
@@ -95,18 +95,6 @@ lcd_panel_in: endpoint {
 		};
 	};
 
-	panel_lvds: panel-lvds {
-		compatible = "panel-lvds";
-		backlight = <&backlight>;
-		status = "disabled";
-
-		port {
-			lvds_panel_in: endpoint {
-				remote-endpoint = <&lvds0_out>;
-			};
-		};
-	};
-
 	poweroff {
 		compatible = "regulator-poweroff";
 		cpu-supply = <&vgen2_reg>;
@@ -733,10 +721,6 @@ &ldb {
 	lvds-channel@0 {
 		port@4 {
 			reg = <4>;
-
-			lvds0_out: endpoint {
-				remote-endpoint = <&lvds_panel_in>;
-			};
 		};
 	};
 

-- 
2.43.0

[PATCH 09/14] ARM: dts: imx6ul-tx6ul: remove front compatible string karo,imx6ul-tx6ul-sgtl5000

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

simple-audio-card needn't front compatible string
karo,imx6ul-tx6ul-sgtl5000. Remove it to fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul-0010.dtb: /sound: failed to match any schema with compatible: ['karo,imx6ul-tx6ul-sgtl5000', 'simple-audio-card']

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
index 2f6916c0359c5..c678f8fc06c28 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
@@ -192,8 +192,7 @@ &gpio1 10 GPIO_ACTIVE_HIGH
 	};
 
 	sound {
-		compatible = "karo,imx6ul-tx6ul-sgtl5000",
-			     "simple-audio-card";
+		compatible = "simple-audio-card";
 		simple-audio-card,name = "imx6ul-tx6ul-sgtl5000-audio";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,bitclock-master = <&codec_dai>;

-- 
2.43.0

[PATCH 10/14] ARM: dts: imx6qdl-tx6-mb7: remove redundant pixelclk-active for simple panel

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

The information pixelclk-active already set in panel-simple.c according to
compatible string. Remove redundant pixelclk-active to fix below CHECK_DTBS
warnings:
  arch/arm/boot/dts/nxp/imx/imx6q-tx6q-10x0-mb7.dtb: lcd-panel (edt,et057090dhu): Unevaluated properties are not allowed ('pixelclk-active' was unexpected)
        from schema $id: http://devicetree.org/schemas/display/panel/panel-simple.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi
index 8232f4ea27526..b770d884c6f3e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi
@@ -17,19 +17,16 @@ backlight1 {
 	lcd-panel {
 		compatible = "edt,et057090dhu";
 		power-supply = <&reg_lcd1_pwr>;
-		pixelclk-active = <0>;
 	};
 
 	lvds0-panel {
 		compatible = "edt,etml1010g0dka";
 		power-supply = <&reg_lcd1_pwr>;
-		pixelclk-active = <0>;
 	};
 
 	lvds1-panel {
 		compatible = "edt,etml1010g0dka";
 		power-supply = <&reg_lcd1_pwr>;
-		pixelclk-active = <0>;
 	};
 };
 

-- 
2.43.0

[PATCH 11/14] ARM: dts: imx6q-h100: rename port to port@0 for mipi_csi

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

mipi_csi port@0 is input port. There are not 'port' at binding doc. Rename
it to port@0 and add reg = <0> to fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6q-h100.dtb: mipi@21dc000 (fsl,imx6-mipi-csi2): 'port' does not match any of the regexes: '^pinctrl-[0-9]+$', '^port@[1-4]$'
        from schema $id: http://devicetree.org/schemas/media/fsl,imx6-mipi-csi2.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6q-h100.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-h100.dts b/arch/arm/boot/dts/nxp/imx/imx6q-h100.dts
index 4c8ea43815597..a5180c655c9a6 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-h100.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-h100.dts
@@ -335,7 +335,9 @@ MX6QDL_PAD_KEY_ROW1__SD2_VSELECT	0x1b0b0
 &mipi_csi {
 	status = "okay";
 
-	port {
+	port@0 {
+		reg = <0>;
+
 		mipi_csi2_in: endpoint {
 			remote-endpoint = <&tc358743_out>;
 			data-lanes = <1 2 3 4>;

-- 
2.43.0

[PATCH 12/14] ARM: dts: imx6qdl-sabrelite: fix typo vync-active

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Fix typo vync-active, which should be vsync-active. Fix below CHECK_DTBS
warnings:
  arch/arm/boot/dts/nxp/imx/imx6dl-sabrelite.dtb: endpoint: vync-active: b'\x00\x00\x00\x01' is not of type 'object', 'integer', 'array', 'boolean', 'null'
        from schema $id: http://devicetree.org/schemas/dt-core.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi
index 3b7d01065e87b..308db8af73719 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi
@@ -234,7 +234,7 @@ &ipu1_csi0_from_ipu1_csi0_mux {
 	bus-width = <8>;
 	data-shift = <12>; /* Lines 19:12 used */
 	hsync-active = <1>;
-	vync-active = <1>;
+	vsync-active = <1>;
 };
 
 &ipu1_csi0_mux_from_parallel_sensor {

-- 
2.43.0

[PATCH 13/14] ARM: dts: imx6q-novena: use interrupts replace irq-gpio

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

irq-gpio is not existing property, which should use interrupts and
interrupt-parent.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6q-novena.dtb: stmpe811@44 (st,stmpe811): 'irq-gpio' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/mfd/st,stmpe.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6q-novena.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-novena.dts b/arch/arm/boot/dts/nxp/imx/imx6q-novena.dts
index 9938a63b5110c..fce04448d932e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-novena.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-novena.dts
@@ -280,7 +280,8 @@ sbs_battery: bq20z75@b {
 	touch: stmpe811@44 {
 		compatible = "st,stmpe811";
 		reg = <0x44>;
-		irq-gpio = <&gpio5 13 GPIO_ACTIVE_HIGH>;
+		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-parent = <&gpio5>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_stmpe_novena>;
 		vio-supply = <&reg_3p3v>;

-- 
2.43.0

[PATCH 14/14] ARM: dts: imx6sx-sdb-mqs: remove empty pinctrl-0

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Remove empty property pinctrl-0 to fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dtb: sai@21d4000 (fsl,imx6sx-sai): pinctrl-0: True is not of type 'array'
        from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
index a4ab2d3e960c4..82ae475a018e1 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
@@ -33,7 +33,6 @@ &mqs {
 };
 
 &sai1 {
-	pinctrl-0 = <>;
 	status = "okay";
 };
 

-- 
2.43.0

Re: [PATCH 14/14] ARM: dts: imx6sx-sdb-mqs: remove empty pinctrl-0

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] ARM: dts: imx6sx-sdb-mqs: inherited sai1 pinctrl-0 conflicts with audmux
--

commit 7833db678f76ab4ca49bd301d79848b89980d394
Author: Frank Li <Frank.Li@nxp.com>

ARM: dts: imx6sx-sdb-mqs: remove empty pinctrl-0

This commit removes the empty pinctrl-0 property from the sai1 node in
imx6sx-sdb-mqs.dts to resolve a dtbs_check schema validation warning.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
> index a4ab2d3e960c4..82ae475a018e1 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
> @@ -33,7 +33,6 @@ &mqs {
>  };
>  
>  &sai1 {
> -	pinctrl-0 = <>;
>  	status = "okay";
>  };
>  

[Severity: High]
Does removing pinctrl-0 = <>; here without using /delete-property/ cause
&sai1 to inherit pinctrl-0 = <&pinctrl_sai1>; from imx6sx-sdb.dtsi and
conflict with &audmux at probe time?

imx6sx-sdb-mqs.dts includes imx6sx-sdb.dts, which includes imx6sx-sdb.dtsi
where &sai1 and &audmux are defined as:

arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi:
    &audmux {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_audmux>;
        status = "okay";
    };
    ...
    &sai1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_sai1>;
        status = "disabled";
    };

In imx6sx-sdb.dtsi, pinctrl_audmux and pinctrl_sai1 configure the same five
CSI pads:

    pinctrl_audmux: audmuxgrp {
        fsl,pins = <
            MX6SX_PAD_CSI_DATA00__AUDMUX_AUD6_TXC   0x130b0
            MX6SX_PAD_CSI_DATA01__AUDMUX_AUD6_TXFS  0x130b0
            MX6SX_PAD_CSI_HSYNC__AUDMUX_AUD6_TXD    0x120b0
            MX6SX_PAD_CSI_VSYNC__AUDMUX_AUD6_RXD    0x130b0
            MX6SX_PAD_CSI_PIXCLK__AUDMUX_MCLK       0x130b0
        >;
    };
    ...
    pinctrl_sai1: sai1grp {
        fsl,pins = <
            MX6SX_PAD_CSI_DATA00__SAI1_TX_BCLK      0x130b0
            MX6SX_PAD_CSI_DATA01__SAI1_TX_SYNC      0x130b0
            MX6SX_PAD_CSI_HSYNC__SAI1_TX_DATA_0     0x120b0
            MX6SX_PAD_CSI_VSYNC__SAI1_RX_DATA_0     0x130b0
            MX6SX_PAD_CSI_PIXCLK__AUDMUX_MCLK       0x130b0
        >;
    };

In MQS mode, sai1 routes audio internally to the MQS block (&mqs, which uses
pinctrl_mqs on SD2_CLK and SD2_CMD) rather than using external SAI1 pins.
Commit 73691f21e211 ("ARM: dts: imx6sx-sdb: Add MQS support") originally set
pinctrl-0 = <>; in imx6sx-sdb-mqs.dts to override pinctrl-0 = <&pinctrl_sai1>;
from imx6sx-sdb.dtsi while leaving &audmux enabled.

When pinctrl-0 = <>; is simply removed, &sai1 retains pinctrl-0 = <&pinctrl_sai1>;
from imx6sx-sdb.dtsi while both &audmux and &sai1 have status = "okay",
causing pinctrl_bind_pins() -> pin_request() to fail with -EINVAL when the
second device probes.

Should this use /delete-property/ pinctrl-0; (and /delete-property/
pinctrl-names;) instead so that the inherited pinctrl properties are removed
from &sai1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-arm_dts_cleanup2-v1-0-3a0cab9fd784@nxp.com?part=14

Re: [PATCH 03/14] ARM: dts: imx6dl-b155v2: add touchscreen size properties

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] ARM: dts: imx6dl-b155v2: panel size in touchscreen-size-x/y breaks touch
--

commit a32e64e0ae8dfc5c902cc7abdcc408b2bb7583c9
Author: Frank Li <Frank.Li@nxp.com>

ARM: dts: imx6dl-b155v2: add touchscreen size properties

This commit adds touchscreen-size-x and touchscreen-size-y properties to the
eeti,exc80h84 touchscreen node in imx6dl-b155v2.dts to satisfy the
eeti,exc3000 devicetree schema requirements.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
> index 7edc788bcb8f3..54db44613df66 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
> @@ -25,6 +25,8 @@ touchscreen@2a {
>  		pinctrl-0 = <&pinctrl_q7_gpio0>;
>  		interrupt-parent = <&gpio5>;
>  		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		touchscreen-size-x = <1366>;
> +		touchscreen-size-y = <768>;
>  		touchscreen-inverted-x;
>  		touchscreen-inverted-y;
>  		reset-gpios = <&tca6424a 21 GPIO_ACTIVE_HIGH>;

[Severity: High]
Does setting touchscreen-size-x and touchscreen-size-y to the display panel's
1366x768 pixel resolution introduce a regression in touch coordinate reporting
for this controller?

Per Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml,
touchscreen-size-x and touchscreen-size-y describe the coordinate space of the
touchscreen controller itself (maximum coordinate reported + 1), rather than
the LCD panel dimensions.

In drivers/input/touchscreen/exc3000.c, exc3000_info defines the native 14-bit
coordinate maximum for the EXC80H84 controller:

	[EETI_EXC80H84] = {
		.name = "EETI EXC80H84 Touch Screen",
		.max_xy = SZ_16K - 1,
	},

During probe, exc3000_probe() initializes the axes to [0, 16383], and then
calls touchscreen_parse_properties():

	max_xy = data->info->max_xy;
	input_set_abs_params(input, ABS_MT_POSITION_X, 0, max_xy, 0, 0);
	input_set_abs_params(input, ABS_MT_POSITION_Y, 0, max_xy, 0, 0);

	touchscreen_parse_properties(input, true, &data->prop);

With touchscreen-size-x = <1366> and touchscreen-size-y = <768>,
touchscreen_parse_properties() overwrites the axis maximums and
data->prop.max_x / max_y to 1365 and 767.

However, the exc3000 driver does not program these dimensions into the
hardware or scale the raw coordinates in software. When a touch interrupt
occurs, exc3000_interrupt() -> exc3000_handle_mt_event() ->
exc3000_report_slots() passes unscaled 14-bit coordinates (0..16383) directly
to touchscreen_report_pos():

	touchscreen_report_pos(input, prop,
			       get_unaligned_le16(buf + 2),
			       get_unaligned_le16(buf + 4),
			       true);

Because touchscreen-inverted-x and touchscreen-inverted-y are also set on
touchscreen@2a, touchscreen_report_pos() -> touchscreen_apply_prop_to_x_y()
inverts the raw coordinates against the overridden maximums:

	if (prop->invert_x)
		*x = prop->max_x - *x;

	if (prop->invert_y)
		*y = prop->max_y - *y;

Whenever the controller reports raw X > 1365 or raw Y > 767, this unsigned
subtraction wraps around and reports negative coordinates to input_report_abs(),
while also advertising the wrong axis range to userspace.

Should touchscreen-size-x and touchscreen-size-y be set to <16384> to match
the EETI EXC80H84 controller's 16384x16384 coordinate space?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-arm_dts_cleanup2-v1-0-3a0cab9fd784@nxp.com?part=3