Re: [PATCH v2 03/13] pinctrl: berlin: enable module build support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] pinctrl: berlin: PINCTRL_BERLIN remains bool and built via
  obj-y
--

commit 74a8c9f28b8b05de9543f2486bac3805aa5dc526
Author: Jisheng Zhang <jszhang@kernel.org>

pinctrl: berlin: enable module build support

This commit converts allocations in the Berlin pinctrl core to devm APIs,
exports the probe helpers, and adds module metadata to support building the
driver as a module.

> diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c
> index 8a612ce2d1d36..a0ae75b1d705d 100644
> --- a/drivers/pinctrl/berlin/berlin.c
> +++ b/drivers/pinctrl/berlin/berlin.c

[ ... ]

> @@ -340,3 +337,7 @@ int berlin_pinctrl_probe(struct platform_device *pdev,
>  
>  	return berlin_pinctrl_probe_regmap(pdev, desc, regmap);
>  }
> +EXPORT_SYMBOL_GPL(berlin_pinctrl_probe);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("pinctrl library for Synaptics SoCs");

[Severity: Medium]
Can berlin.c actually be built as a loadable module when
drivers/pinctrl/berlin/Kconfig still defines the symbol as bool and
drivers/pinctrl/berlin/Makefile builds berlin.o with obj-y?

drivers/pinctrl/berlin/Kconfig:
	config PINCTRL_BERLIN
		bool

drivers/pinctrl/berlin/Makefile:
	obj-y					+= berlin.o

Even when a downstream SoC pinctrl driver is configured as a module,
selecting this symbol forces berlin.o into vmlinux instead of building a
loadable module for vendor_dlkm.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115102401.3520-1-jszhang@kernel.org?part=3