Re: [PATCH v2 13/13] arm64: dts: synaptics: add SL2610 family RDK boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Low] arm64: dts: synaptics: deprecated cpu0-supply used in
  sl261x-rdk-common.dtsi
- [Low] arm64: dts: synaptics: underscore in soc_i2c0-pmux node name
- [Low] arm64: dts: synaptics: unused linux-event-codes.h include in
  sl261x-rdk-common.dtsi
--

commit f1ba81aeb15547b6a1942dc7df6778c88410e949
Author: Jisheng Zhang <jszhang@kernel.org>

arm64: dts: synaptics: add SL2610 family RDK boards

This commit adds device tree files for the Synaptics SL2611, SL2613,
SL2615, SL2617, and SL2619 reference development kits along with a shared
common dtsi.

> diff --git a/arch/arm64/boot/dts/synaptics/sl261x-rdk-common.dtsi b/arch/arm64/boot/dts/synaptics/sl261x-rdk-common.dtsi
> new file mode 100644
> index 0000000000000..78a9b28fdf99e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/synaptics/sl261x-rdk-common.dtsi
> @@ -0,0 +1,135 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2025 Synaptics Incorporated
> + *
> + * Author: Jisheng Zhang <jszhang@kernel.org>
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/linux-event-codes.h>

[Severity: Low]
Is the dt-bindings/input/linux-event-codes.h include needed here? Neither
sl261x-rdk-common.dtsi nor the board dts files that include it define any
input nodes or reference event code macros.

[ ... ]

> +	cpus {
> +		cpu@0 {
> +			cpu0-supply = <&vcore>;
> +		};
> +	};

[Severity: Low]
Should cpu@0 use cpu-supply instead of cpu0-supply?
Documentation/devicetree/bindings/arm/cpus.yaml marks cpu0-supply as
deprecated in favor of cpu-supply, and the dual-core SL2615, SL2617, and
SL2619 variants also define cpu1: cpu@100.

[ ... ]

> +&pinctrl {
> +	soc_i2c0_pmux: soc_i2c0-pmux {
> +		groups = "GPIO23", "GPIO24";
> +		function = "tw2";
> +		drive-strength = <7>;
> +	};
> +};

[Severity: Low]
Should the node name soc_i2c0-pmux use a hyphen instead of an underscore
(for example, soc-i2c0-pmux)? Using an underscore in a devicetree node
name triggers a dtc node_name_chars_strict warning when building with W=2.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115102401.3520-1-jszhang@kernel.org?part=13