Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	wsa+renesas@sang-engineering.com
Subject: Re: [PATCH net-next v5 22/24] net: dsa: rzn1-a5psw: Keep MAC TX enabled on RZ/T2H
Date: Sat, 21 Nov 2026 00:26:27 +0000	[thread overview]
Message-ID: <sashiko-outbox-226422@kernel.org> (raw)
In-Reply-To: <20261120002549.1908299-23-prabhakar.mahadev-lad.rj@bp.renesas.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] net: dsa: rzn1-a5psw: tx_allowed conflates admin enable and
  STP state
--

commit 35401b3c17f803c4cf769c92538ab3bbb602e7e3
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

net: dsa: rzn1-a5psw: Keep MAC TX enabled on RZ/T2H

This commit keeps CMD_CFG.TX_ENA enabled on SoCs that require it, pulsing
the hardware reset line in probe instead of issuing CMD_CFG.SW_RESET and
gating port transmission through A5PSW_PORT_ENA based on link and
administrative/STP state.

> diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
> index 751d03b0bde4c..86d5b9d52f8db 100644
> --- a/drivers/net/dsa/rzn1_a5psw.c
> +++ b/drivers/net/dsa/rzn1_a5psw.c
> @@ -127,11 +127,20 @@ static void a5psw_port_mgmtfwd_set(struct a5psw *a5psw, int port, bool enable)
>  	a5psw_port_pattern_set(a5psw, port, A5PSW_PATTERN_MGMTFWD, enable);
>  }
>  
> -static void a5psw_port_tx_enable(struct a5psw *a5psw, int port, bool enable)
> +/* Must be called with reg_lock held */
> +static void a5psw_port_tx_update(struct a5psw *a5psw, int port)
>  {
>  	u32 mask = A5PSW_PORT_ENA_TX(port);
> -	u32 reg = enable ? mask : 0;
> +	u32 reg;
>  
> +	reg = a5psw_reg_readl(a5psw, A5PSW_PORT_ENA) & ~mask;
> +	if (a5psw->tx_allowed & a5psw->link_up & BIT(port))
> +		reg |= mask;
> +	a5psw_reg_writel(a5psw, A5PSW_PORT_ENA, reg);
> +}
> +
> +static void a5psw_port_tx_enable(struct a5psw *a5psw, int port, bool enable)
> +{
>  	/* Even though the port TX is disabled through TXENA bit in the
>  	 * PORT_ENA register, it can still send BPDUs. This depends on the tag
>  	 * configuration added when sending packets from the CPU port to the
> @@ -140,18 +149,38 @@ static void a5psw_port_tx_enable(struct a5psw *a5psw, int port, bool enable)
>  	 * This allows to implement STP support when ports are in a state where
>  	 * forwarding traffic should be stopped but BPDUs should still be sent.
>  	 */
> -	a5psw_reg_rmw(a5psw, A5PSW_PORT_ENA, mask, reg);
> +	spin_lock(&a5psw->reg_lock);
> +
> +	if (enable)
> +		a5psw->tx_allowed |= BIT(port);
> +	else
> +		a5psw->tx_allowed &= ~BIT(port);
> +
> +	a5psw_port_tx_update(a5psw, port);
> +
> +	spin_unlock(&a5psw->reg_lock);
>  }
>  
> -static void a5psw_port_enable_set(struct a5psw *a5psw, int port, bool enable)
> +static void a5psw_port_link_set(struct a5psw *a5psw, int port, bool up)
>  {
> -	u32 port_ena = 0;
> +	spin_lock(&a5psw->reg_lock);
>  
> -	if (enable)
> -		port_ena |= A5PSW_PORT_ENA_TX_RX(port);
> +	if (up)
> +		a5psw->link_up |= BIT(port);
> +	else
> +		a5psw->link_up &= ~BIT(port);
> +
> +	a5psw_port_tx_update(a5psw, port);
>  
> -	a5psw_reg_rmw(a5psw, A5PSW_PORT_ENA, A5PSW_PORT_ENA_TX_RX(port),
> -		      port_ena);
> +	spin_unlock(&a5psw->reg_lock);
> +}
> +
> +static void a5psw_port_enable_set(struct a5psw *a5psw, int port, bool enable)
> +{
> +	u32 rx_mask = BIT(port + A5PSW_PORT_ENA_RX_SHIFT);
> +
> +	a5psw_reg_rmw(a5psw, A5PSW_PORT_ENA, rx_mask, enable ? rx_mask : 0);
> +	a5psw_port_tx_enable(a5psw, port, enable);
>  }

[Severity: Medium]
Can a5psw_port_enable_set() and a5psw_port_stp_state_set() overwrite each
other's state in a5psw->tx_allowed?

Both callers update the same per-port bit in a5psw->tx_allowed via
a5psw_port_tx_enable().  When a bridged port in BR_STATE_DISABLED is
brought administratively up, dsa_port_enable_rt() calls ds->ops->port_enable()
without resetting the STP state:

net/dsa/port.c:dsa_port_enable_rt() {
    ...
	if (ds->ops->port_enable) {
		err = ds->ops->port_enable(ds, port, phy);
		if (err)
			return err;
	}

	if (!dp->bridge)
		dsa_port_set_state_now(dp, BR_STATE_FORWARDING, false);
    ...
}

a5psw_port_enable() -> a5psw_port_enable_set() then sets BIT(port) in
a5psw->tx_allowed, so once link comes up a5psw_port_link_set() enables
A5PSW_PORT_ENA_TX(port) even though the port is still in BR_STATE_DISABLED
(for example, while the bridge master itself is administratively down).
Conversely, when an administratively down port leaves a bridge,
dsa_port_switchdev_unsync_attrs() sets its STP state back to
BR_STATE_FORWARDING, setting BIT(port) in a5psw->tx_allowed while the port
is still down.

Tracking administrative enable and STP forwarding in separate bitmasks (or
checking both in a5psw_port_tx_update()) would prevent one from overriding
the other.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120002549.1908299-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=22

  reply	other threads:[~2026-11-21  0:26 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  0:25 [PATCH net-next v5 00/24] Add ETHSW support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 01/24] net: dsa: tag_rzn1_a5psw: Drop redundant ETH_P_DSA_A5PSW definition Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 02/24] net: dsa: tag_rzn1_a5psw: Add RZ/T2H ETHSW tag protocol support Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 03/24] net: dsa: Kconfig: Expand config description to cover RZ/T2H and RZ/N2H ETHSW Prabhakar
2026-11-20  9:32   ` Clement Leger
2026-11-20 18:31     ` Lad, Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 04/24] net: pcs: rzn1-miic: Select ETHSW port speed through SWCTRL Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 05/24] dt-bindings: net: dsa: renesas,rzn1-a5psw: Reject the "ports" node Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 06/24] dt-bindings: net: dsa: renesas,rzn1-a5psw: Limit port reg values Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 07/24] dt-bindings: net: dsa: renesas,rzn1-a5psw: Add RZ/T2H and RZ/N2H ETHSW support Prabhakar
2026-11-21  0:26   ` sashiko-bot
2026-11-20  0:25 ` [PATCH net-next v5 08/24] net: dsa: rzn1-a5psw: Fix LK_LEARNCOUNT write mode encoding Prabhakar
2026-11-20  3:27   ` Andrew Lunn
2026-11-20  6:01   ` Clement Leger
2026-11-20 18:29     ` Lad, Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 09/24] net: dsa: rzn1-a5psw: Fix VLANTransmitted counter offset Prabhakar
2026-11-20  3:29   ` Andrew Lunn
2026-11-20 18:28     ` Lad, Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 10/24] net: dsa: rzn1-a5psw: Fix MDIO clock divider calculation Prabhakar
2026-11-20  6:51   ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 11/24] net: dsa: rzn1-a5psw: Set driver data in probe Prabhakar
2026-11-20  6:53   ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 12/24] net: dsa: rzn1-a5psw: Add support for optional reset control Prabhakar
2026-11-20  3:32   ` Andrew Lunn
2026-11-20  0:25 ` [PATCH net-next v5 13/24] net: dsa: rzn1-a5psw: Add support for optional timestamp clock Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 14/24] net: dsa: rzn1-a5psw: Make use dev_err_probe() Prabhakar
2026-11-20  6:58   ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 15/24] net: dsa: rzn1-a5psw: Get switch info via OF data Prabhakar
2026-11-20  7:02   ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 16/24] net: dsa: rzn1-a5psw: Choose tagging protocol based on compatible string Prabhakar
2026-11-20  7:03   ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 17/24] net: dsa: rzn1-a5psw: Add fixed frame length workaround for management port Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 18/24] net: dsa: rzn1-a5psw: Get pattern matcher register offsets from OF data Prabhakar
2026-11-20  9:35   ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 19/24] net: dsa: rzn1-a5psw: Get VLAN_RES field layout " Prabhakar
2026-11-20  9:37   ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 20/24] net: dsa: rzn1-a5psw: Get lookup table size " Prabhakar
2026-11-20  9:44   ` Clement Leger
2026-11-20 18:34     ` Lad, Prabhakar
2026-11-20 19:49       ` Andrew Lunn
2026-11-20 20:04       ` Clement Leger
2026-11-20  0:25 ` [PATCH net-next v5 21/24] net: dsa: rzn1-a5psw: Update CPU port comment for RZ/T2H Prabhakar
2026-11-20  9:45   ` Clement Leger
2026-11-20 18:35     ` Lad, Prabhakar
2026-11-20  0:25 ` [PATCH net-next v5 22/24] net: dsa: rzn1-a5psw: Keep MAC TX enabled on RZ/T2H Prabhakar
2026-11-21  0:26   ` sashiko-bot [this message]
2026-11-20  0:25 ` [PATCH net-next v5 23/24] net: dsa: rzn1-a5psw: Add support for RZ/T2H Ethernet switch Prabhakar
2026-11-21  0:26   ` sashiko-bot
2026-11-20  0:25 ` [PATCH net-next v5 24/24] net: dsa: Kconfig: Enable support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-11-20  0:28 ` [PATCH net-next v5 00/24] Add ETHSW support for Renesas " netdev-bot+sinfo
2026-11-20 14:43   ` Lad, Prabhakar
2026-11-20  3:14 ` Jakub Kicinski
2026-11-20 14:44   ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226422@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox