From: Guenter Roeck <linux@roeck-us.net>
To: Joshua Grisham <josh@joshuagrisham.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
platform-driver-x86@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver
Date: Sun, 15 Dec 2024 10:23:08 -0800 [thread overview]
Message-ID: <04c6066f-b8ff-431c-a093-c25aedf58d3f@roeck-us.net> (raw)
In-Reply-To: <CAMF+KebEX+AM_6O5j=ym6GzZ64qac=Kknd1SKLx6VhJsZG-eiQ@mail.gmail.com>
On 12/15/24 09:19, Joshua Grisham wrote:
> Den sön 15 dec. 2024 kl 17:35 skrev Guenter Roeck <linux@roeck-us.net>:
>>
>> Your v2 is highly unusual. The patch description is the change log,
>> and the patch itself seems to be a diff against v1. Did someone ask you
>> to do that ? Just wondering.
>>
>> Guenter
>>
>
> Hi Guenter, here I was just following a patch guide (or at least,
> attempting to?); should it instead be a whole new patch against
Is that a Linux kernel patch guide ? Please provide a reference if possible.
> for-next instead of a diff from the v1 of the first patch itself?
>
That would have been my expectation, and every revised patch series I have
seen so far did that. This is why I am curious and try to understand why
you didn't do that.
Thanks,
Guenter
next prev parent reply other threads:[~2024-12-15 18:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 16:37 [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver Joshua Grisham
2024-12-09 16:58 ` Guenter Roeck
2024-12-15 14:41 ` Joshua Grisham
2024-12-09 17:03 ` Randy Dunlap
2024-12-15 16:09 ` Joshua Grisham
2024-12-15 16:35 ` Guenter Roeck
2024-12-15 17:19 ` Joshua Grisham
2024-12-15 18:23 ` Guenter Roeck [this message]
2024-12-15 16:53 ` Randy Dunlap
2024-12-09 18:48 ` Ilpo Järvinen
2024-12-15 17:16 ` Joshua Grisham
2024-12-10 6:29 ` Armin Wolf
2024-12-16 14:11 ` Joshua Grisham
2024-12-17 1:41 ` Armin Wolf
2024-12-17 15:07 ` Hans de Goede
2024-12-15 14:13 ` [PATCH v2] " Joshua Grisham
2024-12-15 20:02 ` Armin Wolf
2024-12-15 22:51 ` Joshua Grisham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c6066f-b8ff-431c-a093-c25aedf58d3f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=josh@joshuagrisham.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox