From: Guenter Roeck <linux@roeck-us.net>
To: Joshua Grisham <josh@joshuagrisham.com>,
Randy Dunlap <rdunlap@infradead.org>
Cc: ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
platform-driver-x86@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver
Date: Sun, 15 Dec 2024 08:35:08 -0800 [thread overview]
Message-ID: <90e6a8f6-666b-45cc-ae66-4ccbee0ba08e@roeck-us.net> (raw)
In-Reply-To: <CAMF+Keb0cXc8t8J_T39WJUKydpD2EME92ZWT7SFr_taiCXfvww@mail.gmail.com>
On 12/15/24 08:09, Joshua Grisham wrote:
> Den mån 9 dec. 2024 kl 18:04 skrev Randy Dunlap <rdunlap@infradead.org>:
>>
>> Also needs <linux/sysfs.h>.
>> Maybe <linux/printk.h>.
>> Maybe <linux/err.h>.
>>
>> --
>> ~Randy
>>
>
> Also done in v2 of the patch, thanks Randy! (though no printk.h
> anymore as I removed all pr_* functions.. maybe I should explicitly
> add <linux/dev_printk.h> though? or is it good enough to get it via
> platform_device.h <= device.h <= dev_printk.h ?)
>
> Joshua
>
Your v2 is highly unusual. The patch description is the change log,
and the patch itself seems to be a diff against v1. Did someone ask you
to do that ? Just wondering.
Guenter
next prev parent reply other threads:[~2024-12-15 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 16:37 [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver Joshua Grisham
2024-12-09 16:58 ` Guenter Roeck
2024-12-15 14:41 ` Joshua Grisham
2024-12-09 17:03 ` Randy Dunlap
2024-12-15 16:09 ` Joshua Grisham
2024-12-15 16:35 ` Guenter Roeck [this message]
2024-12-15 17:19 ` Joshua Grisham
2024-12-15 18:23 ` Guenter Roeck
2024-12-15 16:53 ` Randy Dunlap
2024-12-09 18:48 ` Ilpo Järvinen
2024-12-15 17:16 ` Joshua Grisham
2024-12-10 6:29 ` Armin Wolf
2024-12-16 14:11 ` Joshua Grisham
2024-12-17 1:41 ` Armin Wolf
2024-12-17 15:07 ` Hans de Goede
2024-12-15 14:13 ` [PATCH v2] " Joshua Grisham
2024-12-15 20:02 ` Armin Wolf
2024-12-15 22:51 ` Joshua Grisham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e6a8f6-666b-45cc-ae66-4ccbee0ba08e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=josh@joshuagrisham.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox