From: Randy Dunlap <rdunlap@infradead.org>
To: Joshua Grisham <josh@joshuagrisham.com>,
ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
platform-driver-x86@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org, jdelvare@suse.com, linux@roeck-us.net,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver
Date: Mon, 9 Dec 2024 09:03:36 -0800 [thread overview]
Message-ID: <797b248c-7542-43fd-8e44-f2c7d650ccff@infradead.org> (raw)
In-Reply-To: <20241209163720.17597-1-josh@joshuagrisham.com>
Hi,
On 12/9/24 8:37 AM, Joshua Grisham wrote:
> +#include <linux/acpi.h>
> +#include <linux/dmi.h>
> +#include <linux/hwmon.h>
> +#include <linux/i8042.h>
> +#include <linux/init.h>
> +#include <linux/input.h>
> +#include <linux/input/sparse-keymap.h>
> +#include <linux/kernel.h>
> +#include <linux/leds.h>
> +#include <linux/module.h>
> +#include <linux/moduleparam.h>
> +#include <linux/nls.h>
> +#include <linux/platform_device.h>
> +#include <linux/platform_profile.h>
> +#include <linux/serio.h>
> +#include <linux/workqueue.h>
> +#include <acpi/battery.h>
Also needs <linux/sysfs.h>.
Maybe <linux/printk.h>.
Maybe <linux/err.h>.
--
~Randy
next prev parent reply other threads:[~2024-12-09 17:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 16:37 [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver Joshua Grisham
2024-12-09 16:58 ` Guenter Roeck
2024-12-15 14:41 ` Joshua Grisham
2024-12-09 17:03 ` Randy Dunlap [this message]
2024-12-15 16:09 ` Joshua Grisham
2024-12-15 16:35 ` Guenter Roeck
2024-12-15 17:19 ` Joshua Grisham
2024-12-15 18:23 ` Guenter Roeck
2024-12-15 16:53 ` Randy Dunlap
2024-12-09 18:48 ` Ilpo Järvinen
2024-12-15 17:16 ` Joshua Grisham
2024-12-10 6:29 ` Armin Wolf
2024-12-16 14:11 ` Joshua Grisham
2024-12-17 1:41 ` Armin Wolf
2024-12-17 15:07 ` Hans de Goede
2024-12-15 14:13 ` [PATCH v2] " Joshua Grisham
2024-12-15 20:02 ` Armin Wolf
2024-12-15 22:51 ` Joshua Grisham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797b248c-7542-43fd-8e44-f2c7d650ccff@infradead.org \
--to=rdunlap@infradead.org \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=josh@joshuagrisham.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox