From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v3 4/4] Documentation: rs485: Fix struct referencing
Date: Wed, 28 Sep 2022 14:05:09 +0300 [thread overview]
Message-ID: <20220928110509.13544-5-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20220928110509.13544-1-ilpo.jarvinen@linux.intel.com>
Use "struct serial_rs485" to get the references properly recognized.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
.../driver-api/serial/serial-rs485.rst | 21 ++++++++++---------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/Documentation/driver-api/serial/serial-rs485.rst b/Documentation/driver-api/serial/serial-rs485.rst
index 2951dacfb9eb..d902f9de0b0f 100644
--- a/Documentation/driver-api/serial/serial-rs485.rst
+++ b/Documentation/driver-api/serial/serial-rs485.rst
@@ -29,7 +29,7 @@ RS485 Serial Communications
3. Data Structures Already Available in the Kernel
==================================================
- The Linux kernel provides the serial_rs485 structure to handle RS485
+ The Linux kernel provides the struct serial_rs485 to handle RS485
communications. This data structure is used to set and configure RS485
parameters in the platform data and in ioctls.
@@ -39,13 +39,14 @@ RS485 Serial Communications
Any driver for devices capable of working both as RS232 and RS485 should
implement the rs485_config callback and provide rs485_supported in the
- uart_port structure. The serial core calls rs485_config to do the device
- specific part in response to TIOCSRS485 ioctl (see below). The rs485_config
- callback receives a pointer to a sanitizated serial_rs485 structure. The
- serial_rs485 userspace provides is sanitized before calling rs485_config
- using rs485_supported that indicates what RS485 features the driver supports
- for the uart_port. TIOCGRS485 ioctl can be used to read back the
- serial_rs485 structure matching to the current configuration.
+ struct uart_port. The serial core calls rs485_config to do the device
+ specific part in response to TIOCSRS485 ioctl (see below). The
+ rs485_config callback receives a pointer to a sanitizated struct
+ serial_rs485. The struct serial_rs485 userspace provides is sanitized
+ before calling rs485_config using rs485_supported that indicates what
+ RS485 features the driver supports for the struct uart_port. TIOCGRS485
+ ioctl can be used to read back the struct serial_rs485 matching to the
+ current configuration.
.. kernel-doc:: include/uapi/linux/serial.h
:identifiers: serial_rs485 uart_get_rs485_mode
@@ -107,8 +108,8 @@ RS485 Serial Communications
The Linux kernel provides addressing mode for multipoint RS-485 serial
communications line. The addressing mode is enabled with SER_RS485_ADDRB
- flag in serial_rs485. Struct serial_rs485 has two additional flags and
- fields for enabling receive and destination addresses.
+ flag in struct serial_rs485. The struct serial_rs485 has two additional
+ flags and fields for enabling receive and destination addresses.
Address mode flags:
- SER_RS485_ADDRB: Enabled addressing mode (sets also ADDRB in termios).
--
2.30.2
next prev parent reply other threads:[~2022-09-28 11:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 11:05 [PATCH v3 0/4] serial: RS485 kerneldoc/documentation improvements Ilpo Järvinen
2022-09-28 11:05 ` [PATCH v3 1/4] serial: Convert serial_rs485 to kernel doc Ilpo Järvinen
2022-09-29 3:29 ` Bagas Sanjaya
2022-09-29 8:39 ` Ilpo Järvinen
2022-09-29 8:50 ` Bagas Sanjaya
2022-09-29 9:25 ` Ilpo Järvinen
2022-09-28 11:05 ` [PATCH v3 2/4] Documentation: rs485: Link reference properly Ilpo Järvinen
2022-09-28 11:05 ` [PATCH v3 3/4] Documentation: rs485: Mention uart_get_rs485_mode() Ilpo Järvinen
2022-09-28 11:10 ` Andy Shevchenko
2022-09-28 11:52 ` Ilpo Järvinen
2022-09-28 11:05 ` Ilpo Järvinen [this message]
2022-09-28 11:11 ` [PATCH v3 0/4] serial: RS485 kerneldoc/documentation improvements Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928110509.13544-5-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox