From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] Documentation: rs485: Mention uart_get_rs485_mode()
Date: Wed, 28 Sep 2022 14:52:02 +0300 (EEST) [thread overview]
Message-ID: <c4df6e19-5390-3ce8-eb7f-8059115187d0@linux.intel.com> (raw)
In-Reply-To: <CAHp75Vd6OJ68BbaYt21hPpOpDbvT9pow6PSDhedGULjikGhoNg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Wed, 28 Sep 2022, Andy Shevchenko wrote:
> On Wed, Sep 28, 2022 at 2:05 PM Ilpo Järvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
>
> > The device tree can also provide RS485 boot time parameters
> > - [#DT-bindings]_. The driver is in charge of filling this data structure
> > - from the values given by the device tree.
> > + [#DT-bindings]_. The serial core fills the struct serial_rs485 from the
> > + values given by the device tree when driver calls uart_get_rs485_mode().
>
> the driver
>
> Feels like this should be before the previous patch and actually have
> a Fixes tag.
I don't feel it would be an appropriate tag for this kind of cases
where documentation is simply lacking behind what the core code now
offers.
--
i.
next prev parent reply other threads:[~2022-09-28 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 11:05 [PATCH v3 0/4] serial: RS485 kerneldoc/documentation improvements Ilpo Järvinen
2022-09-28 11:05 ` [PATCH v3 1/4] serial: Convert serial_rs485 to kernel doc Ilpo Järvinen
2022-09-29 3:29 ` Bagas Sanjaya
2022-09-29 8:39 ` Ilpo Järvinen
2022-09-29 8:50 ` Bagas Sanjaya
2022-09-29 9:25 ` Ilpo Järvinen
2022-09-28 11:05 ` [PATCH v3 2/4] Documentation: rs485: Link reference properly Ilpo Järvinen
2022-09-28 11:05 ` [PATCH v3 3/4] Documentation: rs485: Mention uart_get_rs485_mode() Ilpo Järvinen
2022-09-28 11:10 ` Andy Shevchenko
2022-09-28 11:52 ` Ilpo Järvinen [this message]
2022-09-28 11:05 ` [PATCH v3 4/4] Documentation: rs485: Fix struct referencing Ilpo Järvinen
2022-09-28 11:11 ` [PATCH v3 0/4] serial: RS485 kerneldoc/documentation improvements Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4df6e19-5390-3ce8-eb7f-8059115187d0@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox