* [PATCH] docs: misc-devices/spear-pcie-gadget.txt: Fix bracket and whitespace
@ 2026-09-05 7:46 Manuel Ebner
2026-09-05 18:12 ` Randy Dunlap
2026-09-07 15:54 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Manuel Ebner @ 2026-09-05 7:46 UTC (permalink / raw)
To: Jonathan Corbet, Shuah Khan; +Cc: Manuel Ebner, linux-doc, linux-kernel
Add missing ')' and remove needless whitespace.
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
Documentation/misc-devices/spear-pcie-gadget.rst | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/misc-devices/spear-pcie-gadget.rst b/Documentation/misc-devices/spear-pcie-gadget.rst
index 09b9d6c7a..13333a209 100644
--- a/Documentation/misc-devices/spear-pcie-gadget.rst
+++ b/Documentation/misc-devices/spear-pcie-gadget.rst
@@ -37,9 +37,9 @@ read behavior of nodes:
-----------------------
=============== ==============================================================
-link gives ltssm status.
-int_type type of supported interrupt
-no_of_msi zero if MSI is not enabled by host. A positive value is the
+link gives ltssm status.
+int_type type of supported interrupt
+no_of_msi zero if MSI is not enabled by host. A positive value is the
number of MSI vector granted.
vendor_id returns programmed vendor id (hex)
device_id returns programmed device id(hex)
@@ -53,7 +53,7 @@ write behavior of nodes:
------------------------
=============== ================================================================
-link write UP to enable ltsmm DOWN to disable
+link write UP to enable ltsmm DOWN to disable
int_type write interrupt type to be configured and (int_type could be
INTA, MSI or NO_INT). Select MSI only when you have programmed
no_of_msi node.
@@ -65,7 +65,7 @@ device_id write device id(hex) to be programmed.
bar0_size write size of bar0 in hex. default bar0 size is 1000 (hex)
bytes.
bar0_address write address of bar0 mapped area in hex. (default mapping of
- bar0 is SYSRAM1(E0800000). Always program bar size before bar
+ bar0 is SYSRAM1(E0800000)). Always program bar size before bar
address. Kernel might modify bar size and address for alignment,
so read back bar size and address after writing to cross check.
bar0_rw_offset write offset of bar0 for which bar0_data will write value.
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: misc-devices/spear-pcie-gadget.txt: Fix bracket and whitespace
2026-09-05 7:46 [PATCH] docs: misc-devices/spear-pcie-gadget.txt: Fix bracket and whitespace Manuel Ebner
@ 2026-09-05 18:12 ` Randy Dunlap
2026-09-07 15:54 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-09-05 18:12 UTC (permalink / raw)
To: Manuel Ebner, Jonathan Corbet, Shuah Khan; +Cc: linux-doc, linux-kernel
On 9/5/26 12:46 AM, Manuel Ebner wrote:
> Add missing ')' and remove needless whitespace.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
Whitespace patches usually fall into my (personal) category of
not worth the hassle or time. Anyway:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Oh, there are 3 places where "MSI vector" should be "MSI vectors".
> ---
> Documentation/misc-devices/spear-pcie-gadget.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/misc-devices/spear-pcie-gadget.rst b/Documentation/misc-devices/spear-pcie-gadget.rst
> index 09b9d6c7a..13333a209 100644
> --- a/Documentation/misc-devices/spear-pcie-gadget.rst
> +++ b/Documentation/misc-devices/spear-pcie-gadget.rst
> @@ -37,9 +37,9 @@ read behavior of nodes:
> -----------------------
>
> =============== ==============================================================
> -link gives ltssm status.
> -int_type type of supported interrupt
> -no_of_msi zero if MSI is not enabled by host. A positive value is the
> +link gives ltssm status.
> +int_type type of supported interrupt
> +no_of_msi zero if MSI is not enabled by host. A positive value is the
> number of MSI vector granted.
> vendor_id returns programmed vendor id (hex)
> device_id returns programmed device id(hex)
> @@ -53,7 +53,7 @@ write behavior of nodes:
> ------------------------
>
> =============== ================================================================
> -link write UP to enable ltsmm DOWN to disable
> +link write UP to enable ltsmm DOWN to disable
> int_type write interrupt type to be configured and (int_type could be
> INTA, MSI or NO_INT). Select MSI only when you have programmed
> no_of_msi node.
> @@ -65,7 +65,7 @@ device_id write device id(hex) to be programmed.
> bar0_size write size of bar0 in hex. default bar0 size is 1000 (hex)
> bytes.
> bar0_address write address of bar0 mapped area in hex. (default mapping of
> - bar0 is SYSRAM1(E0800000). Always program bar size before bar
> + bar0 is SYSRAM1(E0800000)). Always program bar size before bar
> address. Kernel might modify bar size and address for alignment,
> so read back bar size and address after writing to cross check.
> bar0_rw_offset write offset of bar0 for which bar0_data will write value.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: misc-devices/spear-pcie-gadget.txt: Fix bracket and whitespace
2026-09-05 7:46 [PATCH] docs: misc-devices/spear-pcie-gadget.txt: Fix bracket and whitespace Manuel Ebner
2026-09-05 18:12 ` Randy Dunlap
@ 2026-09-07 15:54 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2026-09-07 15:54 UTC (permalink / raw)
To: Manuel Ebner, Shuah Khan; +Cc: Manuel Ebner, linux-doc, linux-kernel
Manuel Ebner <manuelebnerli@mailbox.org> writes:
> Add missing ')' and remove needless whitespace.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> Documentation/misc-devices/spear-pcie-gadget.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Agree with Randy on the white-space fixes, they are generally not worth
it.
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-07 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05 7:46 [PATCH] docs: misc-devices/spear-pcie-gadget.txt: Fix bracket and whitespace Manuel Ebner
2026-09-05 18:12 ` Randy Dunlap
2026-09-07 15:54 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox