From: Jonathan Corbet <corbet@lwn.net>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, gpiccoli@igalia.com,
kernel@gpiccoli.net, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Documentation: Fix duplicate statement about raw_spinlock_t type
Date: Fri, 25 Mar 2022 13:32:12 -0600 [thread overview]
Message-ID: <87r16peslf.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220321144133.49804-1-gpiccoli@igalia.com>
"Guilherme G. Piccoli" <gpiccoli@igalia.com> writes:
> Unless it was duplicate on purpose, to emphasize that a raw_spinlock_t
> is always a spinning lock regardless of PREEMPT_RT or kernel config,
> it's a bit odd that this text is duplicate. So, this patch just clean
> it up, keeping the consistency with the other sections of the text.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Fixes: 919e9e6395cf ("Documentation: Add lock ordering and nesting documentation")
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
> Documentation/locking/locktypes.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
> index bfa75ea1b66a..9933faad4771 100644
> --- a/Documentation/locking/locktypes.rst
> +++ b/Documentation/locking/locktypes.rst
> @@ -211,9 +211,6 @@ raw_spinlock_t and spinlock_t
> raw_spinlock_t
> --------------
>
> -raw_spinlock_t is a strict spinning lock implementation regardless of the
> -kernel configuration including PREEMPT_RT enabled kernels.
> -
> raw_spinlock_t is a strict spinning lock implementation in all kernels,
> including PREEMPT_RT kernels. Use raw_spinlock_t only in real critical
> core code, low-level interrupt handling and places where disabling
I don't think that was intentional. Applied, thanks.
For future reference, a far better changelog would have been something
like:
Remove the duplicated sentence from locktypes.rst
Thanks,
jon
next prev parent reply other threads:[~2022-03-25 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 14:41 [PATCH] Documentation: Fix duplicate statement about raw_spinlock_t type Guilherme G. Piccoli
2022-03-25 19:32 ` Jonathan Corbet [this message]
2022-03-25 19:38 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16peslf.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=gpiccoli@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox