Linux Documentation
 help / color / mirror / Atom feed
* [PATCH] docs: reporting-issues: fix advice wording
@ 2026-05-12  1:51 Chen-Shi-Hong
  2026-05-12  2:03 ` Randy Dunlap
  2026-05-12  6:09 ` Thorsten Leemhuis
  0 siblings, 2 replies; 4+ messages in thread
From: Chen-Shi-Hong @ 2026-05-12  1:51 UTC (permalink / raw)
  To: linux; +Cc: corbet, skhan, linux-doc, linux-kernel, Chen-Shi-Hong

Replace "these advices" with "this advice" in
Documentation/admin-guide/reporting-issues.rst.

Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
---
 Documentation/admin-guide/reporting-issues.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
index 16a66a1f1975..731865b5e8ff 100644
--- a/Documentation/admin-guide/reporting-issues.rst
+++ b/Documentation/admin-guide/reporting-issues.rst
@@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
    situations; during the merge window that actually might be even the best
    approach, but in that development phase it can be an even better idea to
    suspend your efforts for a few days anyway. Whatever version you choose,
-   ideally use a 'vanilla' build. Ignoring these advices will dramatically
+   ideally use a 'vanilla' build. Ignoring this advice will dramatically
    increase the risk your report will be rejected or ignored.
 
  * Ensure the kernel you just installed does not 'taint' itself when
@@ -795,7 +795,7 @@ Install a fresh kernel for testing
     situations; during the merge window that actually might be even the best
     approach, but in that development phase it can be an even better idea to
     suspend your efforts for a few days anyway. Whatever version you choose,
-    ideally use a 'vanilla' built. Ignoring these advices will dramatically
+    ideally use a 'vanilla' built. Ignoring this advice will dramatically
     increase the risk your report will be rejected or ignored.*
 
 As mentioned in the detailed explanation for the first step already: Like most

base-commit: 5d6919055dec134de3c40167a490f33c74c12581
prerequisite-patch-id: 1089bde9e188a84c873ff722a776bc107a6e8103
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: reporting-issues: fix advice wording
  2026-05-12  1:51 [PATCH] docs: reporting-issues: fix advice wording Chen-Shi-Hong
@ 2026-05-12  2:03 ` Randy Dunlap
  2026-05-12  6:09 ` Thorsten Leemhuis
  1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2026-05-12  2:03 UTC (permalink / raw)
  To: Chen-Shi-Hong, linux; +Cc: corbet, skhan, linux-doc, linux-kernel



On 5/11/26 6:51 PM, Chen-Shi-Hong wrote:
> Replace "these advices" with "this advice" in
> Documentation/admin-guide/reporting-issues.rst.
> 
> Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
>  Documentation/admin-guide/reporting-issues.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 16a66a1f1975..731865b5e8ff 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
>     situations; during the merge window that actually might be even the best
>     approach, but in that development phase it can be an even better idea to
>     suspend your efforts for a few days anyway. Whatever version you choose,
> -   ideally use a 'vanilla' build. Ignoring these advices will dramatically
> +   ideally use a 'vanilla' build. Ignoring this advice will dramatically
>     increase the risk your report will be rejected or ignored.
>  
>   * Ensure the kernel you just installed does not 'taint' itself when
> @@ -795,7 +795,7 @@ Install a fresh kernel for testing
>      situations; during the merge window that actually might be even the best
>      approach, but in that development phase it can be an even better idea to
>      suspend your efforts for a few days anyway. Whatever version you choose,
> -    ideally use a 'vanilla' built. Ignoring these advices will dramatically
> +    ideally use a 'vanilla' built. Ignoring this advice will dramatically
>      increase the risk your report will be rejected or ignored.*
>  
>  As mentioned in the detailed explanation for the first step already: Like most
> 
> base-commit: 5d6919055dec134de3c40167a490f33c74c12581
> prerequisite-patch-id: 1089bde9e188a84c873ff722a776bc107a6e8103

-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: reporting-issues: fix advice wording
  2026-05-12  1:51 [PATCH] docs: reporting-issues: fix advice wording Chen-Shi-Hong
  2026-05-12  2:03 ` Randy Dunlap
@ 2026-05-12  6:09 ` Thorsten Leemhuis
  2026-05-12 12:35   ` Jonathan Corbet
  1 sibling, 1 reply; 4+ messages in thread
From: Thorsten Leemhuis @ 2026-05-12  6:09 UTC (permalink / raw)
  To: Chen-Shi-Hong; +Cc: corbet, skhan, linux-doc, linux-kernel

On 5/12/26 03:51, Chen-Shi-Hong wrote:
> Replace "these advices" with "this advice" in
> Documentation/admin-guide/reporting-issues.rst.

Thx for this, fixing this is a good idea. It nevertheless makes me go
"hmmm...", as the wrongly executed and maybe not obvious enough original
intention of the author (disclaimer: me) was to make it a bit clearer
that "this advice" does not only mean the one advice right before it,
but all the pieces of advice in the paragraph. It would be great to
cover that while fixing it. "pieces of advice" maybe? Not sure. Maybe
somebody has a better idea. And maybe just ignore my nitpicking, guess
"this advice" just feels too easy to misinterpret from my point of view
as someone to whom English is a second language.

Ciao, Thorsten


> Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
> ---
>  Documentation/admin-guide/reporting-issues.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 16a66a1f1975..731865b5e8ff 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
>     situations; during the merge window that actually might be even the best
>     approach, but in that development phase it can be an even better idea to
>     suspend your efforts for a few days anyway. Whatever version you choose,
> -   ideally use a 'vanilla' build. Ignoring these advices will dramatically
> +   ideally use a 'vanilla' build. Ignoring this advice will dramatically
>     increase the risk your report will be rejected or ignored.
>  
>   * Ensure the kernel you just installed does not 'taint' itself when
> @@ -795,7 +795,7 @@ Install a fresh kernel for testing
>      situations; during the merge window that actually might be even the best
>      approach, but in that development phase it can be an even better idea to
>      suspend your efforts for a few days anyway. Whatever version you choose,
> -    ideally use a 'vanilla' built. Ignoring these advices will dramatically
> +    ideally use a 'vanilla' built. Ignoring this advice will dramatically
>      increase the risk your report will be rejected or ignored.*
>  
>  As mentioned in the detailed explanation for the first step already: Like most
> 
> base-commit: 5d6919055dec134de3c40167a490f33c74c12581
> prerequisite-patch-id: 1089bde9e188a84c873ff722a776bc107a6e8103


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: reporting-issues: fix advice wording
  2026-05-12  6:09 ` Thorsten Leemhuis
@ 2026-05-12 12:35   ` Jonathan Corbet
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2026-05-12 12:35 UTC (permalink / raw)
  To: Thorsten Leemhuis, Chen-Shi-Hong; +Cc: skhan, linux-doc, linux-kernel

Thorsten Leemhuis <linux@leemhuis.info> writes:

> On 5/12/26 03:51, Chen-Shi-Hong wrote:
>> Replace "these advices" with "this advice" in
>> Documentation/admin-guide/reporting-issues.rst.
>
> Thx for this, fixing this is a good idea. It nevertheless makes me go
> "hmmm...", as the wrongly executed and maybe not obvious enough original
> intention of the author (disclaimer: me) was to make it a bit clearer
> that "this advice" does not only mean the one advice right before it,
> but all the pieces of advice in the paragraph. It would be great to
> cover that while fixing it. "pieces of advice" maybe? Not sure. Maybe
> somebody has a better idea. And maybe just ignore my nitpicking, guess
> "this advice" just feels too easy to misinterpret from my point of view
> as someone to whom English is a second language.

"Advice" is an uncountable thing, so the suggested fix certainly
encompasses the meaning you want.  It could be "all of this advice" or
some such if you want to make its coverage explicitly larger.

jon

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-05-12 12:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12  1:51 [PATCH] docs: reporting-issues: fix advice wording Chen-Shi-Hong
2026-05-12  2:03 ` Randy Dunlap
2026-05-12  6:09 ` Thorsten Leemhuis
2026-05-12 12:35   ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox