From: "Krzysztof Wilczyński" <kw@linux.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
helgaas@kernel.org, wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/4] Introduce pcim_alloc_irq_vectors()
Date: Mon, 15 Feb 2021 22:18:41 +0100 [thread overview]
Message-ID: <YCrlMXCUWwc0fM38@rocinante> (raw)
In-Reply-To: <20210215181550.714101-1-zhengdejin5@gmail.com>
Hi Dejin,
Thank you for working on this series!
Do you have a link to the conversation that prompted addition of this
new function? If so, then it would be nice to include a reference to it
here (as a link to http://lore.kernel.org/) in the cover letter for
reference, if possible, of course.
Generally, it would also be nice to expand on things a little bit and
explain why do you want to add this new function, and what problems does
it solve.
[...]
> Introduce pcim_alloc_irq_vectors(), a explicit device-managed version of
> pci_alloc_irq_vectors(). and use the correct name of device-managed
> function to alloc irq vectors in i2c drivers.
Did you want to use a comma, instead of a period, in the sentence
above? You could also probably drop the word "explicit".
Krzysztof
prev parent reply other threads:[~2021-02-15 21:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 18:15 [PATCH v1 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-15 18:15 ` [PATCH v1 1/4] PCI: " Dejin Zheng
2021-02-15 20:55 ` Krzysztof Wilczyński
2021-02-16 10:12 ` Andy Shevchenko
2021-02-16 14:26 ` Dejin Zheng
2021-02-16 14:41 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 2/4] Documentation: devres: add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-15 21:41 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-15 21:33 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 4/4] i2c: thunderx: " Dejin Zheng
2021-02-15 21:29 ` Krzysztof Wilczyński
2021-02-15 21:18 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCrlMXCUWwc0fM38@rocinante \
--to=kw@linux.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox