From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Dejin Zheng <zhengdejin5@gmail.com>,
corbet@lwn.net, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
helgaas@kernel.org, wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] PCI: Introduce pcim_alloc_irq_vectors()
Date: Tue, 16 Feb 2021 12:12:39 +0200 [thread overview]
Message-ID: <YCual+Fq9mcnxbM4@smile.fi.intel.com> (raw)
In-Reply-To: <YCrfqungNSSxe5lK@rocinante>
On Mon, Feb 15, 2021 at 09:55:06PM +0100, Krzysztof Wilczyński wrote:
> Question: wouldn't you need to call pci_free_irq_vectors() somewhere,
> possibly to pcim_release() callback? Although, I am not sure where the
> right place would be.
>
> I am asking, as the documentation (see [4]) suggests that one would have
> to release allocated IRQ vectors (relevant exceprt):
It's done in pcim_release() but not explicitly.
if (dev->msi_enabled)
pci_disable_msi(dev);
if (dev->msix_enabled)
pci_disable_msix(dev);
Maybe above can be replaced by pci_free_irq_vectors() to be sure that any
future change to PCI IRQ allocation APIs.
Yes, I have checked and currently the above code is equivalent to
pci_free_irq_vectors().
Dejin, please update your patch accordingly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-16 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 18:15 [PATCH v1 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-15 18:15 ` [PATCH v1 1/4] PCI: " Dejin Zheng
2021-02-15 20:55 ` Krzysztof Wilczyński
2021-02-16 10:12 ` Andy Shevchenko [this message]
2021-02-16 14:26 ` Dejin Zheng
2021-02-16 14:41 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 2/4] Documentation: devres: add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-15 21:41 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-15 21:33 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 4/4] i2c: thunderx: " Dejin Zheng
2021-02-15 21:29 ` Krzysztof Wilczyński
2021-02-15 21:18 ` [PATCH v1 0/4] Introduce pcim_alloc_irq_vectors() Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCual+Fq9mcnxbM4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox