From: "Krzysztof Wilczyński" <kw@linux.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
helgaas@kernel.org, wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] Documentation: devres: add pcim_alloc_irq_vectors()
Date: Mon, 15 Feb 2021 22:41:26 +0100 [thread overview]
Message-ID: <YCrqhtAIwMio+PNw@rocinante> (raw)
In-Reply-To: <20210215181550.714101-3-zhengdejin5@gmail.com>
Hello Dejin,
[...]
> add pcim_alloc_irq_vectors(), a explicit device-managed version of
> pci_alloc_irq_vectors().
It would be "Add" at the start of the sentence. You could also drop
the "explicit" word or replace it with "an explicit", if you want to
keep it.
Generally, this commit message could be improved - you could explain
that you are updating the documentation to reflect the addition of this
new function called pcim_alloc_irq_vectors(), and also briefly explain
why it was added, etc.
[...]
> devm_pci_remap_cfg_resource() : ioremap PCI configuration space resource
> + pcim_alloc_irq_vectors() : managed irq vectors allocation
[...]
It would be "IRQ" here.
Krzysztof
next prev parent reply other threads:[~2021-02-15 21:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 18:15 [PATCH v1 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-15 18:15 ` [PATCH v1 1/4] PCI: " Dejin Zheng
2021-02-15 20:55 ` Krzysztof Wilczyński
2021-02-16 10:12 ` Andy Shevchenko
2021-02-16 14:26 ` Dejin Zheng
2021-02-16 14:41 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 2/4] Documentation: devres: add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-15 21:41 ` Krzysztof Wilczyński [this message]
2021-02-15 18:15 ` [PATCH v1 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-15 21:33 ` Krzysztof Wilczyński
2021-02-15 18:15 ` [PATCH v1 4/4] i2c: thunderx: " Dejin Zheng
2021-02-15 21:29 ` Krzysztof Wilczyński
2021-02-15 21:18 ` [PATCH v1 0/4] Introduce pcim_alloc_irq_vectors() Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCrqhtAIwMio+PNw@rocinante \
--to=kw@linux.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox