From: Reinette Chatre <reinette.chatre@intel.com>
To: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
"Peter Newman" <peternewman@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>
Cc: James Morse <james.morse@arm.com>,
Jamie Iles <quic_jiles@quicinc.com>,
Babu Moger <babu.moger@amd.com>,
Randy Dunlap <rdunlap@infradead.org>,
"Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH v8 2/7] x86/resctrl: Compute memory bandwidth for all supported events
Date: Tue, 12 Nov 2024 11:25:15 -0800 [thread overview]
Message-ID: <cd58086a-c242-4105-a112-264533f2596c@intel.com> (raw)
In-Reply-To: <20241029172832.93963-3-tony.luck@intel.com>
Hi Tony,
On 10/29/24 10:28 AM, Tony Luck wrote:
> Computing the bandwidth for an event is cheap, and only done once
> per second. Doing so simplifies switching between events and allows
> choosing different events per ctrl_mon group.
>
If I understand correctly this changelog only describes the first and the
last hunks of this patch. Further, it is the last hunk that introduces the
duplicate code that prompts the refactoring in next patch "x86/resctrl:
Refactor mbm_update()". Inserting the duplicate code and then refactoring it
out does not seem necessary. What if the second hunk of this patch is extracted
into its own patch and the refactoring squashed with what remains?
In the cover letter your motivation for the separate refactor was "to make it
easier to review", but I wonder if separating the unrelated code in second
hunk would make this separate refactor unnecessary while remaining easy to
review?
Reinette
next prev parent reply other threads:[~2024-11-12 19:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 17:28 [PATCH v8 0/7] x86/resctrl: mba_MBps enhancement Tony Luck
2024-10-29 17:28 ` [PATCH v8 1/7] x86/resctrl: Prepare for per-ctrl_mon group mba_MBps control Tony Luck
2024-11-01 22:03 ` Fenghua Yu
2024-11-01 22:40 ` Tony Luck
2024-11-12 19:24 ` Reinette Chatre
2024-10-29 17:28 ` [PATCH v8 2/7] x86/resctrl: Compute memory bandwidth for all supported events Tony Luck
2024-11-12 19:25 ` Reinette Chatre [this message]
2024-10-29 17:28 ` [PATCH v8 3/7] x86/resctrl: Refactor mbm_update() Tony Luck
2024-11-01 22:08 ` Fenghua Yu
2024-11-01 22:57 ` Tony Luck
2024-11-13 22:25 ` Reinette Chatre
2024-11-13 22:58 ` Tony Luck
2024-11-13 23:58 ` Reinette Chatre
2024-11-14 10:31 ` Peter Newman
2024-11-14 17:20 ` Tony Luck
2024-10-29 17:28 ` [PATCH v8 4/7] x86/resctrl: Relax checks for mba_MBps mount option Tony Luck
2024-10-29 17:28 ` [PATCH v8 5/7] x86/resctrl: Add "mba_MBps_event" file to ctrl_mon directories Tony Luck
2024-11-12 22:12 ` Reinette Chatre
2024-11-12 23:42 ` Luck, Tony
2024-11-13 0:20 ` Reinette Chatre
2024-11-13 0:53 ` Luck, Tony
2024-11-13 2:54 ` Reinette Chatre
2024-10-29 17:28 ` [PATCH v8 6/7] x86/resctrl: Add write option to "mba_MBps_event" file Tony Luck
2024-11-01 23:26 ` Fenghua Yu
2024-11-01 23:55 ` Luck, Tony
2024-11-02 0:57 ` Fenghua Yu
2024-11-12 22:00 ` Reinette Chatre
2024-11-12 23:57 ` Luck, Tony
2024-11-13 0:40 ` Reinette Chatre
2024-11-12 22:18 ` Reinette Chatre
2024-10-29 17:28 ` [PATCH v8 7/7] x86/resctrl: Document the new " Tony Luck
2024-11-12 22:25 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd58086a-c242-4105-a112-264533f2596c@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=corbet@lwn.net \
--cc=fenghua.yu@intel.com \
--cc=james.morse@arm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tan.shaopeng@fujitsu.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox