From: "Li,Rongqing(ACG CCN)" <lirongqing@baidu.com>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
Usama Arif <usama.arif@linux.dev>
Cc: Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Harry Yoo <harry@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Hao Li" <hao.li@linux.dev>, Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: 答复: 答复: 答复: [外部邮件] Re: [PATCH] mm/mempool: use static key for boot-time debug enablement
Date: Mon, 1 Jun 2026 01:28:15 +0000 [thread overview]
Message-ID: <d22239c31657481483e25ab347231d53@baidu.com> (raw)
In-Reply-To: <2c1b8eff-f613-4407-b5f3-4d8b12d34321@kernel.org>
> On 5/28/26 14:59, Usama Arif wrote:
> >
> >
> > On 28/05/2026 11:50, Li,Rongqing(ACG CCN) wrote:
> >>
> >>
> >>>
> >>> On 28/05/2026 04:00, Li,Rongqing(ACG CCN) wrote:
> >>>
> >>> I think 32 bit ARM doesnt?
> >>
> >> You are right, 32-bit ARM doesn't.
> >>
> >> However, the correct architectural approach should be fixing the boot
> >> sequence inside arch/arm/ to match arm64 , powerpc and m68k, rather
> >> than compromising core MM code with temporary boilerplate variables.
> >>
> >> I prefer to keep the mempool implementation clean. If ARM32 triggers
> >> the warning, the proper remedy is a follow-up patch to align its
> >> setup_arch() ordering.
> >>
> >> What do you think?
> >>
> >
> > I think it would be a prerequisite rather than a follow up patch
> > inorder to not break 32 bit arm. I will let ARM and slab maintainers decide
> on this.
>
> Yeah we shouldn't just knowingly break it.
> But I kind of doubt the argument that crucial mempool allocations happen
> that early in the boot and we could miss errors in them? They are mostly
> storage drivers, AFAICS. So I don't think we need the debugging to be enabled
> early.
>
After some grep in kernel,I agree with you.
Using __setup should be perfectly fine for this mempool parameter.
Thanks
[Li,Rongqing]
next prev parent reply other threads:[~2026-06-01 1:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 10:46 [PATCH] mm/mempool: use static key for boot-time debug enablement lirongqing
2026-05-27 13:03 ` Usama Arif
2026-05-27 16:43 ` Vlastimil Babka (SUSE)
2026-05-28 3:00 ` 答复: [外部邮件] " Li,Rongqing(ACG CCN)
2026-05-28 10:33 ` Usama Arif
2026-05-28 10:50 ` 答复: " Li,Rongqing(ACG CCN)
2026-05-28 12:59 ` Usama Arif
2026-05-29 9:39 ` Vlastimil Babka (SUSE)
2026-06-01 1:28 ` Li,Rongqing(ACG CCN) [this message]
2026-05-27 20:06 ` Andrew Morton
2026-05-28 7:54 ` Vlastimil Babka (SUSE)
2026-05-27 21:29 ` Christoph Lameter (Ampere)
2026-05-27 22:13 ` Matthew Wilcox
2026-05-27 23:06 ` Christoph Lameter (Ampere)
2026-05-27 23:09 ` Matthew Wilcox
2026-05-28 7:57 ` 答复: [????] " Li,Rongqing(ACG CCN)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d22239c31657481483e25ab347231d53@baidu.com \
--to=lirongqing@baidu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=corbet@lwn.net \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox