[PATCHv1] drivers: edac: This patch fix the following checkpatch warning.

Linux EDAC development
 help / color / mirror / Atom feed

* [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
@ 2019-04-14 18:41 Mohan Kumar
  2019-04-14 18:41 ` [PATCH] " Mohan Kumar
  2019-04-14 18:49 ` Borislav Petkov
  0 siblings, 2 replies; 6+ messages in thread
From: Mohan Kumar @ 2019-04-14 18:41 UTC (permalink / raw)
  To: bp; +Cc: mchehab, james.morse, linux-edac, linux-kernel

Use pr_warn instead of printk

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
        then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
---
 drivers/edac/x38_edac.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
index cc779f3..4c855c0 100644
--- a/drivers/edac/x38_edac.c
+++ b/drivers/edac/x38_edac.c
@@ -14,6 +14,7 @@
 #include <linux/pci.h>
 #include <linux/pci_ids.h>
 #include <linux/edac.h>
+#include <linux/netdevice.h>
 
 #include <linux/io-64-nonatomic-lo-hi.h>
 #include "edac_module.h"
@@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
 	u.mchbar &= X38_MCHBAR_MASK;
 
 	if (u.mchbar != (resource_size_t)u.mchbar) {
-		printk(KERN_ERR
+		pr_err(
 			"x38: mmio space beyond accessible range (0x%llx)\n",
 			(unsigned long long)u.mchbar);
 		return NULL;
@@ -268,7 +269,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
 
 	window = ioremap_nocache(u.mchbar, X38_MMR_WINDOW_SIZE);
 	if (!window)
-		printk(KERN_ERR "x38: cannot map mmio space at 0x%llx\n",
+		pr_err("x38: cannot map mmio space at 0x%llx\n",
 			(unsigned long long)u.mchbar);
 
 	return window;

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
  2019-04-14 18:41 [PATCHv1] drivers: edac: This patch fix the following checkpatch warning Mohan Kumar
@ 2019-04-14 18:41 ` Mohan Kumar
  2019-04-14 18:49 ` Borislav Petkov
  1 sibling, 0 replies; 6+ messages in thread
From: Mohan Kumar @ 2019-04-14 18:41 UTC (permalink / raw)
  To: bp; +Cc: mchehab, james.morse, linux-edac, linux-kernel

Use pr_warn instead of printk

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
        then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
---
 drivers/edac/x38_edac.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
index cc779f3..4c855c0 100644
--- a/drivers/edac/x38_edac.c
+++ b/drivers/edac/x38_edac.c
@@ -14,6 +14,7 @@
 #include <linux/pci.h>
 #include <linux/pci_ids.h>
 #include <linux/edac.h>
+#include <linux/netdevice.h>
 
 #include <linux/io-64-nonatomic-lo-hi.h>
 #include "edac_module.h"
@@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
 	u.mchbar &= X38_MCHBAR_MASK;
 
 	if (u.mchbar != (resource_size_t)u.mchbar) {
-		printk(KERN_ERR
+		pr_err(
 			"x38: mmio space beyond accessible range (0x%llx)\n",
 			(unsigned long long)u.mchbar);
 		return NULL;
@@ -268,7 +269,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
 
 	window = ioremap_nocache(u.mchbar, X38_MMR_WINDOW_SIZE);
 	if (!window)
-		printk(KERN_ERR "x38: cannot map mmio space at 0x%llx\n",
+		pr_err("x38: cannot map mmio space at 0x%llx\n",
 			(unsigned long long)u.mchbar);
 
 	return window;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
@ 2019-04-14 18:49 ` Borislav Petkov
  2019-04-14 18:49   ` [PATCH] " Borislav Petkov
       [not found]   ` <CAKr-_Nj2=t-Oc3iNsnC9jBywftAwY8C6wMH+mdfiMPvgzdpYGA@mail.gmail.com>
  0 siblings, 2 replies; 6+ messages in thread
From: Borislav Petkov @ 2019-04-14 18:49 UTC (permalink / raw)
  To: Mohan Kumar; +Cc: mchehab, james.morse, linux-edac, linux-kernel

On Sun, Apr 14, 2019 at 09:41:50PM +0300, Mohan Kumar wrote:
> Use pr_warn instead of printk
> 
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
>         then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Please read this here first on what to put in your patch title and commit
message:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
> ---
>  drivers/edac/x38_edac.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> index cc779f3..4c855c0 100644
> --- a/drivers/edac/x38_edac.c
> +++ b/drivers/edac/x38_edac.c
> @@ -14,6 +14,7 @@
>  #include <linux/pci.h>
>  #include <linux/pci_ids.h>
>  #include <linux/edac.h>
> +#include <linux/netdevice.h>
>  
>  #include <linux/io-64-nonatomic-lo-hi.h>
>  #include "edac_module.h"
> @@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
>  	u.mchbar &= X38_MCHBAR_MASK;
>  
>  	if (u.mchbar != (resource_size_t)u.mchbar) {
> -		printk(KERN_ERR
> +		pr_err(
>  			"x38: mmio space beyond accessible range (0x%llx)\n",

Put those two on a single line so that you don't have an ugly linebreak
like that.

Thx.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
  2019-04-14 18:49 ` Borislav Petkov
@ 2019-04-14 18:49   ` Borislav Petkov
       [not found]   ` <CAKr-_Nj2=t-Oc3iNsnC9jBywftAwY8C6wMH+mdfiMPvgzdpYGA@mail.gmail.com>
  1 sibling, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2019-04-14 18:49 UTC (permalink / raw)
  To: Mohan Kumar; +Cc: mchehab, james.morse, linux-edac, linux-kernel

On Sun, Apr 14, 2019 at 09:41:50PM +0300, Mohan Kumar wrote:
> Use pr_warn instead of printk
> 
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
>         then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Please read this here first on what to put in your patch title and commit
message:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
> ---
>  drivers/edac/x38_edac.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> index cc779f3..4c855c0 100644
> --- a/drivers/edac/x38_edac.c
> +++ b/drivers/edac/x38_edac.c
> @@ -14,6 +14,7 @@
>  #include <linux/pci.h>
>  #include <linux/pci_ids.h>
>  #include <linux/edac.h>
> +#include <linux/netdevice.h>
>  
>  #include <linux/io-64-nonatomic-lo-hi.h>
>  #include "edac_module.h"
> @@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
>  	u.mchbar &= X38_MCHBAR_MASK;
>  
>  	if (u.mchbar != (resource_size_t)u.mchbar) {
> -		printk(KERN_ERR
> +		pr_err(
>  			"x38: mmio space beyond accessible range (0x%llx)\n",

Put those two on a single line so that you don't have an ugly linebreak
like that.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <CAKr-_Nj2=t-Oc3iNsnC9jBywftAwY8C6wMH+mdfiMPvgzdpYGA@mail.gmail.com>]

* [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
@ 2019-04-14 20:16     ` Borislav Petkov
  2019-04-14 20:16       ` [PATCH] " Borislav Petkov
  0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2019-04-14 20:16 UTC (permalink / raw)
  To: mohan kumar; +Cc: mchehab, james.morse, linux-edac, linux-kernel

On Sun, Apr 14, 2019 at 10:09:49PM +0300, mohan kumar wrote:
> Ok Thanks, I will do that.

Good.

One more thing: please do not top-post when replying on public mailing
lists.

Thx.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
  2019-04-14 20:16     ` Borislav Petkov
@ 2019-04-14 20:16       ` Borislav Petkov
  0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2019-04-14 20:16 UTC (permalink / raw)
  To: mohan kumar; +Cc: mchehab, james.morse, linux-edac, linux-kernel

On Sun, Apr 14, 2019 at 10:09:49PM +0300, mohan kumar wrote:
> Ok Thanks, I will do that.

Good.

One more thing: please do not top-post when replying on public mailing
lists.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-04-14 20:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-14 18:41 [PATCHv1] drivers: edac: This patch fix the following checkpatch warning Mohan Kumar
2019-04-14 18:41 ` [PATCH] " Mohan Kumar
2019-04-14 18:49 ` Borislav Petkov
2019-04-14 18:49   ` [PATCH] " Borislav Petkov
     [not found]   ` <CAKr-_Nj2=t-Oc3iNsnC9jBywftAwY8C6wMH+mdfiMPvgzdpYGA@mail.gmail.com>
2019-04-14 20:16     ` Borislav Petkov
2019-04-14 20:16       ` [PATCH] " Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox