[PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

[PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

[Tom Rix]

smatch reports
drivers/edac/amd64_edac.c:990:3: warning: symbol
  'gpu_node_map' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/edac/amd64_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 5d7c080d96a2..597dae7692b1 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -984,7 +984,7 @@ static int sys_addr_to_csrow(struct mem_ctl_info *mci, u64 sys_addr)
  * system and what the lowest AMD Node ID value is for the GPU nodes. Use this
  * info to fixup the Linux logical "Node ID" value set in the AMD NB code and EDAC.
  */
-struct local_node_map {
+static struct local_node_map {
 	u16 node_count;
 	u16 base_node_id;
 } gpu_node_map;
-- 
2.27.0

Re: [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

[Yazen Ghannam]

On 6/10/2023 5:09 PM, Tom Rix wrote:
> smatch reports
> drivers/edac/amd64_edac.c:990:3: warning: symbol
>    'gpu_node_map' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 

Hi Tom,

Please use "imperative mood" when describing the change.

"This variable is only used in its defining file, so add the 'static' 
keyword to it."

or

"Make gpu_node_map static, since it's only used in its defining file."

Also, would a Fixes tag be appropriate?

Otherwise, looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen

Re: [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

[Borislav Petkov]

On Wed, Jun 14, 2023 at 11:21:46AM -0400, Yazen Ghannam wrote:
> Also, would a Fixes tag be appropriate?

No need. I've squashed this with the topmost commit in tip:ras/core
which introduced gpu_node_map in the first place.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette