From: Serge Semin <fancer.lancer@gmail.com>
To: Michal Simek <michal.simek@amd.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Manish Narani <manish.narani@xilinx.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Borislav Petkov <bp@suse.de>
Subject: [PATCH RESEND v6 03/18] EDAC/synopsys: Drop erroneous ADDRMAP4.addrmap_col_b10 parse
Date: Thu, 27 Jun 2024 20:32:10 +0300 [thread overview]
Message-ID: <20240627173251.25718-4-fancer.lancer@gmail.com> (raw)
In-Reply-To: <20240627173251.25718-1-fancer.lancer@gmail.com>
Currently the ADDRMAP4.addrmap_col_b10 field gets to be parsed in case of
the LPDDR3 memory and Quarter DQ bus width mode. It's wrong since that
field is marked as unused for that mode in all the available DW uMCTL2
DDRC releases (up to IP-core v3.91a). Most likely the field parsing was
added by mistake as a result of the copy-paste from the Half DQ bus width
mode part of the same function. Even though the field is supposed to be
always set to the UNUSED value (0x1F) drop parsing it anyway so to
simplify the setup_column_address_map() method a tiny bit.
Fixes: 1a81361f75d8 ("EDAC, synopsys: Add Error Injection support for ZynqMP DDR controller")
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---
drivers/edac/synopsys_edac.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index 2b23d5ef9cff..88db777f3d90 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -1236,10 +1236,6 @@ static void setup_column_address_map(struct synps_edac_priv *priv, u32 *addrmap)
COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 :
(((addrmap[3] >> 24) & COL_MAX_VAL_MASK) +
COL_B9_BASE);
- priv->col_shift[13] = ((addrmap[4] &
- COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 :
- ((addrmap[4] & COL_MAX_VAL_MASK) +
- COL_B10_BASE);
} else {
priv->col_shift[11] = (((addrmap[3] >> 16) &
COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 :
--
2.43.0
next prev parent reply other threads:[~2024-06-27 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 17:32 [PATCH RESEND v6 00/18] EDAC/mc/synopsys: Various fixes and cleanups Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 01/18] EDAC/synopsys: Fix generic device type detection procedure Serge Semin
2024-06-28 6:01 ` Borislav Petkov
2024-06-27 17:32 ` [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub_cap field setting Serge Semin
2024-07-09 11:35 ` Borislav Petkov
2024-07-11 15:11 ` Serge Semin
2024-06-27 17:32 ` Serge Semin [this message]
2024-06-27 17:32 ` [PATCH RESEND v6 04/18] EDAC/synopsys: Fix reading errors count before ECC status Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 05/18] EDAC/synopsys: Fix misleading IRQ self-cleared quirk flag Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 06/18] EDAC/synopsys: Drop internal CE and UE counters Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 07/18] EDAC/synopsys: Drop local to_mci() macro definition Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 08/18] EDAC/synopsys: Drop struct ecc_error_info.blknr field Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 09/18] EDAC/synopsys: Shorten out struct ecc_error_info.bankgrpnr field name Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 10/18] EDAC/synopsys: Drop redundant info from the error messages Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 11/18] EDAC/mc: Init DIMM labels in MC registration method Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 12/18] EDAC/mc: Add generic unique MC index allocation procedure Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 13/18] EDAC/mc: Re-use " Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 14/18] EDAC/synopsys: Detach Zynq A05 DDRC support to separate driver Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 15/18] EDAC/synopsys: Drop unused platform-specific setup API Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 16/18] EDAC/synopsys: Unify CSRs macro declarations Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 17/18] EDAC/synopsys: Unify struct/macro/function prefixes Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 18/18] EDAC/synopsys: Convert to using BIT/GENMASK/FIELD_x macros Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627173251.25718-4-fancer.lancer@gmail.com \
--to=fancer.lancer@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=punnaiah.choudary.kalluri@xilinx.com \
--cc=rric@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox