From: Steven Rostedt <rostedt@goodmis.org>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Cc: Avadhut Naik <avadhut.naik@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>, "Luck, Tony" <tony.luck@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"john.allen@amd.com" <john.allen@amd.com>
Subject: Re: [PATCH v6 2/5] tracing: Add __print_dynamic_array() helper
Date: Thu, 17 Oct 2024 09:54:19 -0400 [thread overview]
Message-ID: <20241017095419.2c4a7943@gandalf.local.home> (raw)
In-Reply-To: <CY8PR11MB7134B1AA1F13546D2B84728089472@CY8PR11MB7134.namprd11.prod.outlook.com>
On Thu, 17 Oct 2024 06:58:30 +0000
"Zhuo, Qiuxu" <qiuxu.zhuo@intel.com> wrote:
> When running the check below:
>
> ${LINUX}/scripts/checkpatch.pl --strict <this patch>
>
> it complains:
>
> CHECK: Macro argument 'el_size' may be better as '(el_size)' to avoid precedence issues
> #36: FILE: include/trace/stages/stage3_trace_output.h:123:
> +#define __print_dynamic_array(array, el_size) \
> + ({ \
> + __print_array(__get_dynamic_array(array), \
> + __get_dynamic_array_len(array) / el_size, \
> + el_size); \
> + })
For once I actually agree with checkpatch in an include/trace file.
I can send another version for you.
-- Steve
next prev parent reply other threads:[~2024-10-17 13:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 6:36 [PATCH v6 0/5] MCE wrapper and support for new SMCA syndrome MSRs Avadhut Naik
2024-10-16 6:36 ` [PATCH v6 1/5] x86/mce: Add wrapper for struct mce to export vendor specific info Avadhut Naik
2024-10-17 6:02 ` Zhuo, Qiuxu
2024-10-17 18:09 ` Naik, Avadhut
2024-10-16 6:36 ` [PATCH v6 2/5] tracing: Add __print_dynamic_array() helper Avadhut Naik
2024-10-17 6:58 ` Zhuo, Qiuxu
2024-10-17 13:54 ` Steven Rostedt [this message]
2024-10-18 2:34 ` Zhuo, Qiuxu
2024-10-16 6:36 ` [PATCH v6 3/5] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers Avadhut Naik
2024-10-17 7:09 ` Zhuo, Qiuxu
2024-10-17 21:49 ` Naik, Avadhut
2024-10-18 2:24 ` Zhuo, Qiuxu
2024-10-18 15:28 ` Luck, Tony
2024-10-21 6:29 ` Naik, Avadhut
2024-10-16 6:36 ` [PATCH v6 4/5] x86/mce/apei: Handle variable register array size Avadhut Naik
2024-10-16 6:36 ` [PATCH v6 5/5] EDAC/mce_amd: Add support for FRU Text in MCA Avadhut Naik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017095419.2c4a7943@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=qiuxu.zhuo@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox