From: Nikolay Borisov <nik.borisov@suse.com>
To: linux-edac@vger.kernel.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
Nikolay Borisov <nik.borisov@suse.com>
Subject: [PATCH 1/3] x86/mce/inject: Remova call to mce_notify_irq()
Date: Tue, 14 Jan 2025 18:37:20 +0200 [thread overview]
Message-ID: <20250114163722.34850-2-nik.borisov@suse.com> (raw)
In-Reply-To: <20250114163722.34850-1-nik.borisov@suse.com>
The call is actually a noop because when the MCE is raised the early
notifier is the only call site that correctly calls mce_notify_irq()
because it also sets mce_need_notify. So let's just remove this call,
which allows to unexport mce_notify_irq.
Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
---
arch/x86/kernel/cpu/mce/core.c | 1 -
arch/x86/kernel/cpu/mce/inject.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 7fb5556a0b53..e87676d86a85 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -1793,7 +1793,6 @@ int mce_notify_irq(void)
}
return 0;
}
-EXPORT_SYMBOL_GPL(mce_notify_irq);
static void __mcheck_cpu_mce_banks_init(void)
{
diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c
index 313fe682db33..06e3cf7229ce 100644
--- a/arch/x86/kernel/cpu/mce/inject.c
+++ b/arch/x86/kernel/cpu/mce/inject.c
@@ -229,7 +229,6 @@ static int raise_local(void)
} else if (m->status) {
pr_info("Starting machine check poll CPU %d\n", cpu);
raise_poll(m);
- mce_notify_irq();
pr_info("Machine check poll done on CPU %d\n", cpu);
} else
m->finished = 0;
--
2.43.0
next prev parent reply other threads:[~2025-01-14 16:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 16:37 [PATCH 0/3] Cleanup mce_notify_irq usage Nikolay Borisov
2025-01-14 16:37 ` Nikolay Borisov [this message]
2025-01-14 16:37 ` [PATCH 2/3] x86/mce: Make mce_notify_irq() static Nikolay Borisov
2025-01-14 16:37 ` [PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY Nikolay Borisov
2025-01-15 6:37 ` [PATCH 0/3] Cleanup mce_notify_irq usage Zhuo, Qiuxu
2025-01-15 6:59 ` Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 0/3] Make mce_notify_irq() static Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 1/3] x86/mce/inject: Remova call to mce_notify_irq() Nikolay Borisov
2025-01-22 18:24 ` Yazen Ghannam
2025-01-23 16:00 ` Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 2/3] x86/mce: Make mce_notify_irq() static Nikolay Borisov
2025-01-15 13:37 ` Zhuo, Qiuxu
2025-01-15 13:42 ` Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY Nikolay Borisov
2025-01-15 13:45 ` Zhuo, Qiuxu
2025-01-15 15:02 ` Nikolay Borisov
2025-01-24 10:43 ` Zhuo, Qiuxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114163722.34850-2-nik.borisov@suse.com \
--to=nik.borisov@suse.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox