From: Nikolay Borisov <nik.borisov@suse.com>
To: linux-edac@vger.kernel.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
Nikolay Borisov <nik.borisov@suse.com>
Subject: [RESEND PATCH 2/3] x86/mce: Make mce_notify_irq() static
Date: Wed, 15 Jan 2025 09:36:39 +0200 [thread overview]
Message-ID: <20250115073640.77099-3-nik.borisov@suse.com> (raw)
In-Reply-To: <20250115073640.77099-1-nik.borisov@suse.com>
It's no longer used outside of core.c so let's make it static. No
functional changes.
Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
---
arch/x86/include/asm/mce.h | 2 --
arch/x86/kernel/cpu/mce/core.c | 43 +++++++++++++++++-----------------
2 files changed, 22 insertions(+), 23 deletions(-)
diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
index eb2db07ef39c..6c77c03139f7 100644
--- a/arch/x86/include/asm/mce.h
+++ b/arch/x86/include/asm/mce.h
@@ -296,8 +296,6 @@ enum mcp_flags {
void machine_check_poll(enum mcp_flags flags, mce_banks_t *b);
-bool mce_notify_irq(void);
-
DECLARE_PER_CPU(struct mce, injectm);
/* Disable CMCI/polling for MCA bank claimed by firmware */
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 23e5e7f7c554..89625ff79c3b 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -584,6 +584,28 @@ bool mce_is_correctable(struct mce *m)
}
EXPORT_SYMBOL_GPL(mce_is_correctable);
+/*
+ * Notify the user(s) about new machine check events.
+ * Can be called from interrupt context, but not from machine check/NMI
+ * context.
+ */
+static int mce_notify_irq(void)
+{
+ /* Not more than two messages every minute */
+ static DEFINE_RATELIMIT_STATE(ratelimit, 60*HZ, 2);
+
+ if (test_and_clear_bit(0, &mce_need_notify)) {
+ mce_work_trigger();
+
+ if (__ratelimit(&ratelimit))
+ pr_info(HW_ERR "Machine check events logged\n");
+
+ return 1;
+ }
+
+ return 0;
+}
+
static int mce_early_notifier(struct notifier_block *nb, unsigned long val,
void *data)
{
@@ -1773,27 +1795,6 @@ static void mce_timer_delete_all(void)
del_timer_sync(&per_cpu(mce_timer, cpu));
}
-/*
- * Notify the user(s) about new machine check events.
- * Can be called from interrupt context, but not from machine check/NMI
- * context.
- */
-bool mce_notify_irq(void)
-{
- /* Not more than two messages every minute */
- static DEFINE_RATELIMIT_STATE(ratelimit, 60*HZ, 2);
-
- if (test_and_clear_bit(0, &mce_need_notify)) {
- mce_work_trigger();
-
- if (__ratelimit(&ratelimit))
- pr_info(HW_ERR "Machine check events logged\n");
-
- return true;
- }
- return false;
-}
-
static void __mcheck_cpu_mce_banks_init(void)
{
struct mce_bank *mce_banks = this_cpu_ptr(mce_banks_array);
--
2.43.0
next prev parent reply other threads:[~2025-01-15 7:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 16:37 [PATCH 0/3] Cleanup mce_notify_irq usage Nikolay Borisov
2025-01-14 16:37 ` [PATCH 1/3] x86/mce/inject: Remova call to mce_notify_irq() Nikolay Borisov
2025-01-14 16:37 ` [PATCH 2/3] x86/mce: Make mce_notify_irq() static Nikolay Borisov
2025-01-14 16:37 ` [PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY Nikolay Borisov
2025-01-15 6:37 ` [PATCH 0/3] Cleanup mce_notify_irq usage Zhuo, Qiuxu
2025-01-15 6:59 ` Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 0/3] Make mce_notify_irq() static Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 1/3] x86/mce/inject: Remova call to mce_notify_irq() Nikolay Borisov
2025-01-22 18:24 ` Yazen Ghannam
2025-01-23 16:00 ` Nikolay Borisov
2025-01-15 7:36 ` Nikolay Borisov [this message]
2025-01-15 13:37 ` [RESEND PATCH 2/3] x86/mce: Make mce_notify_irq() static Zhuo, Qiuxu
2025-01-15 13:42 ` Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY Nikolay Borisov
2025-01-15 13:45 ` Zhuo, Qiuxu
2025-01-15 15:02 ` Nikolay Borisov
2025-01-24 10:43 ` Zhuo, Qiuxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115073640.77099-3-nik.borisov@suse.com \
--to=nik.borisov@suse.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox