From: Nikolay Borisov <nik.borisov@suse.com>
To: linux-edac@vger.kernel.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
Nikolay Borisov <nik.borisov@suse.com>
Subject: [RESEND PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY
Date: Wed, 15 Jan 2025 09:36:40 +0200 [thread overview]
Message-ID: <20250115073640.77099-4-nik.borisov@suse.com> (raw)
In-Reply-To: <20250115073640.77099-1-nik.borisov@suse.com>
mce_notify_irq() really depends on the legacy mcelog being enabled as
otherwise mce_work_trigger() will never schedule the trigger work as
mce_helper can't be set unless CONFIG_X86_MCELOG_LEGACY is defined.
Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
---
arch/x86/kernel/cpu/mce/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 89625ff79c3b..b21aa1494da0 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -591,6 +591,7 @@ EXPORT_SYMBOL_GPL(mce_is_correctable);
*/
static int mce_notify_irq(void)
{
+#ifdef CONFIG_X86_MCELOG_LEGACY
/* Not more than two messages every minute */
static DEFINE_RATELIMIT_STATE(ratelimit, 60*HZ, 2);
@@ -602,7 +603,7 @@ static int mce_notify_irq(void)
return 1;
}
-
+#endif
return 0;
}
--
2.43.0
next prev parent reply other threads:[~2025-01-15 7:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 16:37 [PATCH 0/3] Cleanup mce_notify_irq usage Nikolay Borisov
2025-01-14 16:37 ` [PATCH 1/3] x86/mce/inject: Remova call to mce_notify_irq() Nikolay Borisov
2025-01-14 16:37 ` [PATCH 2/3] x86/mce: Make mce_notify_irq() static Nikolay Borisov
2025-01-14 16:37 ` [PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY Nikolay Borisov
2025-01-15 6:37 ` [PATCH 0/3] Cleanup mce_notify_irq usage Zhuo, Qiuxu
2025-01-15 6:59 ` Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 0/3] Make mce_notify_irq() static Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 1/3] x86/mce/inject: Remova call to mce_notify_irq() Nikolay Borisov
2025-01-22 18:24 ` Yazen Ghannam
2025-01-23 16:00 ` Nikolay Borisov
2025-01-15 7:36 ` [RESEND PATCH 2/3] x86/mce: Make mce_notify_irq() static Nikolay Borisov
2025-01-15 13:37 ` Zhuo, Qiuxu
2025-01-15 13:42 ` Nikolay Borisov
2025-01-15 7:36 ` Nikolay Borisov [this message]
2025-01-15 13:45 ` [RESEND PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY Zhuo, Qiuxu
2025-01-15 15:02 ` Nikolay Borisov
2025-01-24 10:43 ` Zhuo, Qiuxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115073640.77099-4-nik.borisov@suse.com \
--to=nik.borisov@suse.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox