Linux EDAC development
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Rounak Das <rounakdas2025@gmail.com>
Cc: bp@alien8.de, tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] EDAC/altera: use SDMMC compatibles to select A10/S10 IRQ layout
Date: Wed, 24 Jun 2026 09:55:20 -0500	[thread overview]
Message-ID: <706ccef9-4f8c-4d03-973d-8e63e76917f8@kernel.org> (raw)
In-Reply-To: <CAPYTKoNq4894bH5r3bAXLNDogWw52sFg-GCP4H7EDY+L871XHQ@mail.gmail.com>



On 6/16/26 18:58, Rounak Das wrote:
> Thank you for the review.
> 
> I originally used the altr,socfpga-s10-sdmmc-ecc compatible because in
> altr_portb_setup() np is the SD/MMC ECC node (found via
> of_find_compatible_node(…, “altr,socfpga-sdmmc-ecc”)) so reusing that
> felt natural there. I later realised that shifting to
> altr,socfpga-s10-ecc-manager is better especially in scenarios where
> np could be any child node.
> 
> In v3, the compatible is read on the manager node. To avoid repeated
> calls (as you have mentioned), I have decided to store it as a `bool
> is_s10` in `struct altr_arria10_edac`

Doh...sorry about that. Will retest version 3.

Dinh


  reply	other threads:[~2026-06-24 14:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 19:15 [PATCH] EDAC/altera: use SDMMC compatibles to select A10/S10 IRQ layout AZ9tumas
2026-06-15 20:27 ` Borislav Petkov
2026-06-16  8:17 ` [PATCH v2] " Rounak Das
2026-06-16 14:44   ` Dinh Nguyen
     [not found]     ` <3131206B-1E30-4EED-A327-D6FD39E6C4E8@gmail.com>
2026-06-16 23:58       ` Rounak Das
2026-06-24 14:55         ` Dinh Nguyen [this message]
2026-06-17  0:07     ` [PATCH v3] EDAC/altera: use ECC manager compatible " Rounak Das
2026-06-18 10:37       ` Dinh Nguyen
2026-06-18 13:26         ` Rounak Das
2026-06-25 12:09       ` Dinh Nguyen
2026-06-26  8:22         ` Rounak Das
2026-06-26 13:42           ` Dinh Nguyen
     [not found]   ` <4a6cf8c0-e425-4381-adf3-daaa1b20ba96@kernel.org>
2026-06-24 14:18     ` [PATCH v2] EDAC/altera: use SDMMC compatibles " Rounak Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=706ccef9-4f8c-4d03-973d-8e63e76917f8@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rounakdas2025@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox