* [PATCH] EDAC,wq: remove unneeded flush_workqueue
@ 2022-04-24 6:21 cgel.zte
2022-08-25 8:58 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-24 6:21 UTC (permalink / raw)
To: bp
Cc: mchehab, tony.luck, james.morse, rric, linux-edac, linux-kernel,
ran jianping, Zeal Robot
From: ran jianping <ran.jianping@zte.com.cn>
All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/edac/wq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
index d021d287eaec..ad3f516627c5 100644
--- a/drivers/edac/wq.c
+++ b/drivers/edac/wq.c
@@ -37,7 +37,6 @@ int edac_workqueue_setup(void)
void edac_workqueue_teardown(void)
{
- flush_workqueue(wq);
destroy_workqueue(wq);
wq = NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] EDAC,wq: remove unneeded flush_workqueue
2022-04-24 6:21 [PATCH] EDAC,wq: remove unneeded flush_workqueue cgel.zte
@ 2022-08-25 8:58 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2022-08-25 8:58 UTC (permalink / raw)
To: cgel.zte
Cc: mchehab, tony.luck, james.morse, rric, linux-edac, linux-kernel,
ran jianping, Zeal Robot
On Sun, Apr 24, 2022 at 06:21:26AM +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
> drivers/edac/wq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
> index d021d287eaec..ad3f516627c5 100644
> --- a/drivers/edac/wq.c
> +++ b/drivers/edac/wq.c
> @@ -37,7 +37,6 @@ int edac_workqueue_setup(void)
>
> void edac_workqueue_teardown(void)
> {
> - flush_workqueue(wq);
> destroy_workqueue(wq);
> wq = NULL;
> }
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-25 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-24 6:21 [PATCH] EDAC,wq: remove unneeded flush_workqueue cgel.zte
2022-08-25 8:58 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox