[PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

[PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

[Ard Biesheuvel]

Fix two instances of pointer type errors, a harmless one where a const void*
value is assigned to a non-const void* variable, and a not-so-harmless one where
we pass a pointer to unsigned long where a pointer to int is expected.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/firmware/efi/efi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index cd36deb619fa..fe737832a882 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -353,8 +353,8 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
 				       int depth, void *data)
 {
 	struct param_info *info = data;
-	void *prop, *dest;
-	unsigned long len;
+	void const *prop, *dest;
+	int len;
 	u64 val;
 	int i;
 
-- 
1.8.3.2

Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

[Matt Fleming]

On Fri, 13 Jun, at 04:54:59PM, Ard Biesheuvel wrote:
> Fix two instances of pointer type errors, a harmless one where a const void*
> value is assigned to a non-const void* variable, and a not-so-harmless one where
> we pass a pointer to unsigned long where a pointer to int is expected.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  drivers/firmware/efi/efi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index cd36deb619fa..fe737832a882 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -353,8 +353,8 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
>  				       int depth, void *data)
>  {
>  	struct param_info *info = data;
> -	void *prop, *dest;
> -	unsigned long len;
> +	void const *prop, *dest;
> +	int len;
>  	u64 val;
>  	int i;

const void *?

-- 
Matt Fleming, Intel Open Source Technology Center

Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

[Ard Biesheuvel]

On 18 June 2014 11:02, Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> wrote:
> On Fri, 13 Jun, at 04:54:59PM, Ard Biesheuvel wrote:
>> Fix two instances of pointer type errors, a harmless one where a const void*
>> value is assigned to a non-const void* variable, and a not-so-harmless one where
>> we pass a pointer to unsigned long where a pointer to int is expected.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>  drivers/firmware/efi/efi.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
>> index cd36deb619fa..fe737832a882 100644
>> --- a/drivers/firmware/efi/efi.c
>> +++ b/drivers/firmware/efi/efi.c
>> @@ -353,8 +353,8 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
>>                                      int depth, void *data)
>>  {
>>       struct param_info *info = data;
>> -     void *prop, *dest;
>> -     unsigned long len;
>> +     void const *prop, *dest;
>> +     int len;
>>       u64 val;
>>       int i;
>
> const void *?
>

You say potato, I say po-tah-to?
But seriously, whichever you prefer ...

Regards,
Ard.

Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

[Matt Fleming]

On Wed, 18 Jun, at 11:06:09AM, Ard Biesheuvel wrote:
> 
> You say potato, I say po-tah-to?
> But seriously, whichever you prefer ...

$ git grep "const void" | wc -l
4441

$ git grep "void const" | wc -l
50

I say potato, you say "tasty carbohydrate ball"

But yeah, it's not a big deal and I can fix this up when applying.

-- 
Matt Fleming, Intel Open Source Technology Center

Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

[Ard Biesheuvel]

On 18 June 2014 11:28, Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> wrote:
> On Wed, 18 Jun, at 11:06:09AM, Ard Biesheuvel wrote:
>>
>> You say potato, I say po-tah-to?
>> But seriously, whichever you prefer ...
>
> $ git grep "const void" | wc -l
> 4441
>
> $ git grep "void const" | wc -l
> 50
>
> I say potato, you say "tasty carbohydrate ball"
>
> But yeah, it's not a big deal and I can fix this up when applying.
>

Actually, it appears I messed up the subject line too:
s/fdt_uefi_find_params/fdt_find_uefi_params/

Cheers,
Ard.