From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: linux-erofs@lists.ozlabs.org
Cc: Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH 2/7] erofs-utils: lib: silence `INTEGER_OVERFLOW`
Date: Tue, 30 Jun 2026 10:52:19 +0800 [thread overview]
Message-ID: <20260630025224.3955763-2-hsiangkao@linux.alibaba.com> (raw)
In-Reply-To: <20260630025224.3955763-1-hsiangkao@linux.alibaba.com>
Coverity-id: 647269
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
lib/metabox.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/metabox.c b/lib/metabox.c
index 86a708367dc0..5c2eadacaf7f 100644
--- a/lib/metabox.c
+++ b/lib/metabox.c
@@ -133,6 +133,10 @@ int erofs_metazone_flush(struct erofs_sb_info *sbi)
return PTR_ERR(bh);
erofs_mapbh(NULL, bh->block);
pos_out = erofs_btell(bh, false);
+ if (__erofs_unlikely(pos_out == EROFS_NULL_ADDR)) {
+ erofs_bdrop(bh, true);
+ return -EFAULT;
+ }
meta_blkaddr = pos_out >> sbi->blkszbits;
sbi->metazone_startblk = meta_blkaddr;
@@ -148,7 +152,7 @@ int erofs_metazone_flush(struct erofs_sb_info *sbi)
do {
count = min_t(erofs_off_t, length, INT_MAX);
- ret = erofs_io_xcopy(sbi->bmgr->vf, pos_out,
+ ret = erofs_io_xcopy(sbi->bmgr->vf, (off_t)pos_out,
&m2gr->vf, count, false);
if (ret < 0)
break;
--
2.43.5
next prev parent reply other threads:[~2026-06-30 2:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 2:52 [PATCH 1/7] erofs-utils: lib: fix `ictx` leak in the failure path Gao Xiang
2026-06-30 2:52 ` Gao Xiang [this message]
2026-06-30 2:52 ` [PATCH 3/7] erofs-utils: lib: fix `PRINTF_ARGS` Gao Xiang
2026-06-30 2:52 ` [PATCH 4/7] erofs-utils: mount: fix `RESOURCE_LEAK` Gao Xiang
2026-06-30 2:52 ` [PATCH 5/7] erofs-utils: lib: fix `STRING_NULL` in nbd.c Gao Xiang
2026-06-30 2:52 ` [PATCH 6/7] erofs-utils: mount: fix `RESOURCE_LEAK` Gao Xiang
2026-06-30 2:52 ` [PATCH 7/7] erofs-utils: lib: silence `INTEGER_OVERFLOW` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630025224.3955763-2-hsiangkao@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox