Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: linux-erofs@lists.ozlabs.org
Cc: Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH 6/7] erofs-utils: mount: fix `RESOURCE_LEAK`
Date: Tue, 30 Jun 2026 10:52:23 +0800	[thread overview]
Message-ID: <20260630025224.3955763-6-hsiangkao@linux.alibaba.com> (raw)
In-Reply-To: <20260630025224.3955763-1-hsiangkao@linux.alibaba.com>

Coverity-id: 647246
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 mount/main.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/mount/main.c b/mount/main.c
index ffe718a0a90f..ec27dcb53eb3 100644
--- a/mount/main.c
+++ b/mount/main.c
@@ -1698,8 +1698,11 @@ static int erofsmount_loopmount(const char *source, const char *mountpoint,
 		return -errno;
 
 	num = ioctl(fd, LOOP_CTL_GET_FREE);
-	if (num < 0)
-		return -errno;
+	if (num < 0) {
+		dfd = -errno;
+		close(fd);
+		return dfd;
+	}
 	close(fd);
 
 	snprintf(device, sizeof(device), "/dev/loop%d", num);
-- 
2.43.5



  parent reply	other threads:[~2026-06-30  2:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  2:52 [PATCH 1/7] erofs-utils: lib: fix `ictx` leak in the failure path Gao Xiang
2026-06-30  2:52 ` [PATCH 2/7] erofs-utils: lib: silence `INTEGER_OVERFLOW` Gao Xiang
2026-06-30  2:52 ` [PATCH 3/7] erofs-utils: lib: fix `PRINTF_ARGS` Gao Xiang
2026-06-30  2:52 ` [PATCH 4/7] erofs-utils: mount: fix `RESOURCE_LEAK` Gao Xiang
2026-06-30  2:52 ` [PATCH 5/7] erofs-utils: lib: fix `STRING_NULL` in nbd.c Gao Xiang
2026-06-30  2:52 ` Gao Xiang [this message]
2026-06-30  2:52 ` [PATCH 7/7] erofs-utils: lib: silence `INTEGER_OVERFLOW` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630025224.3955763-6-hsiangkao@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox