Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: linux-erofs@lists.ozlabs.org
Cc: Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH 7/7] erofs-utils: lib: silence `INTEGER_OVERFLOW`
Date: Tue, 30 Jun 2026 10:52:24 +0800	[thread overview]
Message-ID: <20260630025224.3955763-7-hsiangkao@linux.alibaba.com> (raw)
In-Reply-To: <20260630025224.3955763-1-hsiangkao@linux.alibaba.com>

Coverity-id: 647247
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 lib/inode.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/inode.c b/lib/inode.c
index 9f1553e8db2b..267694f83fdf 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -670,10 +670,13 @@ static int erofs_write_unencoded_data(struct erofs_inode *inode,
 	if (bh) {
 		bmgr = (struct erofs_bufmgr *)bh->block->buffers.fsprivate;
 		pos = erofs_btell(bh, false);
+		if (__erofs_unlikely(pos == EROFS_NULL_ADDR))
+			return -EFAULT;
+
 		do {
 			len = min_t(u64, remaining,
 				    round_down(UINT_MAX, 1U << sbi->blkszbits));
-			ret = erofs_io_xcopy(bmgr->vf, pos, vf, len, noseek);
+			ret = erofs_io_xcopy(bmgr->vf, (off_t)pos, vf, len, noseek);
 			if (ret)
 				return ret;
 			pos += len;
-- 
2.43.5



      parent reply	other threads:[~2026-06-30  2:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  2:52 [PATCH 1/7] erofs-utils: lib: fix `ictx` leak in the failure path Gao Xiang
2026-06-30  2:52 ` [PATCH 2/7] erofs-utils: lib: silence `INTEGER_OVERFLOW` Gao Xiang
2026-06-30  2:52 ` [PATCH 3/7] erofs-utils: lib: fix `PRINTF_ARGS` Gao Xiang
2026-06-30  2:52 ` [PATCH 4/7] erofs-utils: mount: fix `RESOURCE_LEAK` Gao Xiang
2026-06-30  2:52 ` [PATCH 5/7] erofs-utils: lib: fix `STRING_NULL` in nbd.c Gao Xiang
2026-06-30  2:52 ` [PATCH 6/7] erofs-utils: mount: fix `RESOURCE_LEAK` Gao Xiang
2026-06-30  2:52 ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630025224.3955763-7-hsiangkao@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox