Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

[Dave Kleikamp <shaggy@austin.ibm.com>]

On Fri, 2006-09-08 at 00:30 +0200, Jan Kara wrote:
> diff -rupX /home/jack/.kerndiffexclude
> linux-2.6.18-rc6/fs/jbd/commit.c
> linux-2.6.18-rc6-1-orderedwrite/fs/jbd/commit.c
> --- linux-2.6.18-rc6/fs/jbd/commit.c    2006-09-06 18:20:48.000000000
> +0200
> +++ linux-2.6.18-rc6-1-orderedwrite/fs/jbd/commit.c     2006-09-08
> 01:05:35.000000000 +0200
> @@ -160,6 +160,117 @@ static int journal_write_commit_record(j
>         return (ret == -EIO);
>  }
>  
> +void journal_do_submit_data(struct buffer_head **wbuf, int bufs)

Is there any reason this couldn't be static?

> +{
> +       int i;
> +
> +       for (i = 0; i < bufs; i++) {
> +               wbuf[i]->b_end_io = end_buffer_write_sync;
> +               /* We use-up our safety reference in submit_bh() */
> +               submit_bh(WRITE, wbuf[i]);
> +       }
> +} 

I'm rebasing the ext4 work on the latest -mm tree and would like to
avoid renaming this function in the jbd2 clone.

Thanks,
Shaggy
-- 
David Kleikamp
IBM Linux Technology Center