public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Andrew Morton <akpm@osdl.org>, Jan Kara <jack@suse.cz>,
	Badari Pulavarty <pbadari@us.ibm.com>,
	Anton Altaparmakov <aia21@cam.ac.uk>,
	sct@redhat.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	ext4 <linux-ext4@vger.kernel.org>
Subject: [PATCH] JBD: Make journal_do_submit_data static
Date: Thu, 28 Sep 2006 10:03:56 -0500	[thread overview]
Message-ID: <1159455836.12007.2.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <451AF4B5.1090607@sandeen.net>

On Wed, 2006-09-27 at 17:01 -0500, Eric Sandeen wrote:
> Andrew Morton wrote:
> > On Wed, 13 Sep 2006 15:25:19 -0500
> > Dave Kleikamp <shaggy@austin.ibm.com> wrote:
> > 
> >>> +void journal_do_submit_data(struct buffer_head **wbuf, int bufs)
> >> Is there any reason this couldn't be static?
> > 
> > Nope.
> 
> With this change, journal_brelse_array can also be made static in
> recovery.c, and removed from jbd.h, I think.

Looks like it.  Here's a patch to do that:

JBD: Make journal_brelse_array static

It's always good to make symbols static when we can, and this also
eliminates the need to rename the function in jbd2

suggested by Eric Sandeen

Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: Eric Sandeen <sandeen@sandeen.net>

diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c
index 445eed6..11563fe 100644
--- a/fs/jbd/recovery.c
+++ b/fs/jbd/recovery.c
@@ -46,7 +46,7 @@ static int scan_revoke_records(journal_t
 #ifdef __KERNEL__
 
 /* Release readahead buffers after use */
-void journal_brelse_array(struct buffer_head *b[], int n)
+static void journal_brelse_array(struct buffer_head *b[], int n)
 {
 	while (--n >= 0)
 		brelse (b[n]);
diff --git a/include/linux/jbd.h b/include/linux/jbd.h
index a6d9daa..fe89444 100644
--- a/include/linux/jbd.h
+++ b/include/linux/jbd.h
@@ -977,7 +977,6 @@ extern void	   journal_write_revoke_reco
 extern int	journal_set_revoke(journal_t *, unsigned long, tid_t);
 extern int	journal_test_revoke(journal_t *, unsigned long, tid_t);
 extern void	journal_clear_revoke(journal_t *);
-extern void	journal_brelse_array(struct buffer_head *b[], int n);
 extern void	journal_switch_revoke_table(journal_t *journal);
 
 /*

-- 
David Kleikamp
IBM Linux Technology Center


      reply	other threads:[~2006-09-28 15:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-01 15:50 [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers Badari Pulavarty
2006-09-01 16:12 ` Anton Altaparmakov
2006-09-01 16:32   ` Badari Pulavarty
2006-09-01 17:18     ` Andrew Morton
2006-09-01 17:43       ` Badari Pulavarty
2006-09-01 21:01       ` Badari Pulavarty
2006-09-05 16:11       ` Badari Pulavarty
2006-09-06 12:47         ` Jan Kara
2006-09-06 15:12           ` Badari Pulavarty
2006-09-06 15:34             ` Jan Kara
2006-09-06 16:19               ` Badari Pulavarty
2006-09-06 16:27                 ` Jan Kara
2006-09-06 16:43                   ` Badari Pulavarty
2006-09-06 17:03                     ` Jan Kara
2006-09-06 17:16                   ` Badari Pulavarty
2006-09-06 17:27                     ` Jan Kara
2006-09-07  2:14                       ` Andrew Morton
2006-09-07  3:04                         ` Badari Pulavarty
2006-09-07  3:34                           ` Andrew Morton
2006-09-07 15:11                       ` Badari Pulavarty
2006-09-07 20:48                         ` Jan Kara
2006-09-07 22:30                         ` Jan Kara
2006-09-08  4:33                           ` Badari Pulavarty
2006-09-08  8:25                             ` Jan Kara
2006-09-08 14:35                               ` Badari Pulavarty
2006-09-11  9:46                                 ` Jan Kara
2006-09-11 20:45                                   ` Badari Pulavarty
2006-09-11 20:52                                     ` Jan Kara
2006-09-13 20:25                           ` Dave Kleikamp
2006-09-14  3:38                             ` Andrew Morton
2006-09-27 22:01                               ` Eric Sandeen
2006-09-28 15:03                                 ` Dave Kleikamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1159455836.12007.2.camel@kleikamp.austin.ibm.com \
    --to=shaggy@austin.ibm.com \
    --cc=aia21@cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=sandeen@sandeen.net \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox