public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ext3: dump dentry in ext3_dx_add_entry
@ 2015-02-03  9:22 Olaf Hering
  2015-02-03 10:39 ` Bernd Schubert
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2015-02-03  9:22 UTC (permalink / raw)
  To: linux-ext4; +Cc: Olaf Hering, Jan Kara, Andrew Morton, Andreas Dilger

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
---
 fs/ext3/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
index f197736..0692058 100644
--- a/fs/ext3/namei.c
+++ b/fs/ext3/namei.c
@@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
 		if (levels && (dx_get_count(frames->entries) ==
 			       dx_get_limit(frames->entries))) {
 			ext3_warning(sb, __func__,
-				     "Directory index full!");
+				     "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
 			err = -ENOSPC;
 			goto cleanup;
 		}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext3: dump dentry in ext3_dx_add_entry
  2015-02-03  9:22 [PATCH] ext3: dump dentry in ext3_dx_add_entry Olaf Hering
@ 2015-02-03 10:39 ` Bernd Schubert
  0 siblings, 0 replies; 2+ messages in thread
From: Bernd Schubert @ 2015-02-03 10:39 UTC (permalink / raw)
  To: Olaf Hering, linux-ext4; +Cc: Jan Kara, Andrew Morton, Andreas Dilger



On 02/03/2015 10:22 AM, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> ---
>  fs/ext3/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index f197736..0692058 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
>  		if (levels && (dx_get_count(frames->entries) ==
>  			       dx_get_limit(frames->entries))) {
>  			ext3_warning(sb, __func__,
> -				     "Directory index full!");
> +				     "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
>  			err = -ENOSPC;
>  			goto cleanup;
>  		}

Would you mind to also add the inode number? That way one could use
debugfs to figure out the complete path.
And it should be done for ext4 as well.



Cheers,
Bernd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-03 10:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-03  9:22 [PATCH] ext3: dump dentry in ext3_dx_add_entry Olaf Hering
2015-02-03 10:39 ` Bernd Schubert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox