public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs : Fix memory leak in ext2fs_initialize.
Date: Fri, 11 Jul 2008 14:41:49 -0400	[thread overview]
Message-ID: <20080711184149.GB26656@mit.edu> (raw)
In-Reply-To: <ea11fea30807110332n459593eay3ce43cca67d5c676@mail.gmail.com>

On Fri, Jul 11, 2008 at 04:02:06PM +0530, Manish Katiyar wrote:
> +	if (buf) {
> +	 ext2fs_free_mem(&buf);
> +	}

I'll fix this up and apply, but in the future, please respect the
surrounding whitespace rules of the source code.  For e2fsprogs that
means (among other things) each level is indented 8 spaces, no curly
braces are needed for single statements, and no white space at the end
of lines.

Thanks,

							- Ted

  reply	other threads:[~2008-07-11 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11 10:32 [PATCH] e2fsprogs : Fix memory leak in ext2fs_initialize Manish Katiyar
2008-07-11 18:41 ` Theodore Tso [this message]
2008-07-11 18:53   ` Manish Katiyar
2008-07-11 18:46 ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711184149.GB26656@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mkatiyar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox