From: "Manish Katiyar" <mkatiyar@gmail.com>
To: linux-ext4@vger.kernel.org, "Theodore Tso" <tytso@mit.edu>
Subject: [PATCH] e2fsprogs : Fix memory leak in ext2fs_initialize.
Date: Fri, 11 Jul 2008 16:02:06 +0530 [thread overview]
Message-ID: <ea11fea30807110332n459593eay3ce43cca67d5c676@mail.gmail.com> (raw)
In function ext2fs_initialize(), if we fail doing
ext2fs_allocate_block_bitmap() or ext2fs_allocate_inode_bitmap() we
directly goto cleanup and
don't free the memory allocated to buf. Below patch fixes it.
===========================================================
Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
---
lib/ext2fs/initialize.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/lib/ext2fs/initialize.c b/lib/ext2fs/initialize.c
index 011656f..a8375d9 100644
--- a/lib/ext2fs/initialize.c
+++ b/lib/ext2fs/initialize.c
@@ -105,7 +105,7 @@ errcode_t ext2fs_initialize(const char *name, int flags,
int rsv_gdt;
int csum_flag;
int io_flags;
- char *buf;
+ char *buf = 0;
char c;
if (!param || !param->s_blocks_count)
@@ -429,6 +429,9 @@ ipg_retry:
*ret_fs = fs;
return 0;
cleanup:
+ if (buf) {
+ ext2fs_free_mem(&buf);
+ }
ext2fs_free(fs);
return retval;
}
--
1.5.4.3
===========================================================
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
next reply other threads:[~2008-07-11 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 10:32 Manish Katiyar [this message]
2008-07-11 18:41 ` [PATCH] e2fsprogs : Fix memory leak in ext2fs_initialize Theodore Tso
2008-07-11 18:53 ` Manish Katiyar
2008-07-11 18:46 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea11fea30807110332n459593eay3ce43cca67d5c676@mail.gmail.com \
--to=mkatiyar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox