Re: [PATCH] e2fsprogs : Fix memory leak in ext2fs_initialize.

["Manish Katiyar" <mkatiyar@gmail.com>]

On Sat, Jul 12, 2008 at 12:11 AM, Theodore Tso <tytso@mit.edu> wrote:
> On Fri, Jul 11, 2008 at 04:02:06PM +0530, Manish Katiyar wrote:
>> +     if (buf) {
>> +      ext2fs_free_mem(&buf);
>> +     }
>
> I'll fix this up and apply, but in the future, please respect the
> surrounding whitespace rules of the source code.  For e2fsprogs that
> means (among other things) each level is indented 8 spaces, no curly
> braces are needed for single statements, and no white space at the end
> of lines.

Thanks a lot Ted,
 I will keep that in mind in future. I am not sure from where did
those white spaces came, I don't have them in my git log.....and curly
braces for single statements were because I copied the style from
below line in ext2fs_free() .... perhaps a bad example which I chose
to follow :-(

	if (fs->io) {
		io_channel_close(fs->io);
	}

Thanks -


>
> Thanks,
>
>                                                        - Ted
>



-- 
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************