From: Alexey Dobriyan <adobriyan@gmail.com>
To: ralf.hildebrandt@charite.de
Cc: akpm@osdl.org, linux-ext4@vger.kernel.org
Subject: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully
Date: Sat, 6 Sep 2008 01:06:52 +0400 [thread overview]
Message-ID: <20080905210652.GE11569@x200.localdomain> (raw)
Ralf, please confirm.
[PATCH] ext4: fix #11321: create /proc/ext4/*/stats more carefully
ext4 creates per-suberblock directory in /proc/ext4/ . Name used as
basis is taken from bdevname, which, surprise, can contain slash.
However, proc while allowing to use proc_create("a/b", parent) form of
PDE creation, assumes that parent/a was already created.
bdevname in question is 'cciss/c0d0p9', directory is not created and all
this stuff goes directly into /proc (which is real bug).
Warning comes when _second_ partition is mounted.
http://bugzilla.kernel.org/show_bug.cgi?id=11321
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
fs/ext4/mballoc.c | 9 +++++++++
1 file changed, 9 insertions(+)
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2792,6 +2792,15 @@ static int ext4_mb_init_per_dev_proc(struct super_block *sb)
return -EINVAL;
}
bdevname(sb->s_bdev, devname);
+ {
+ char *p = devname;
+
+ while (*p != '\0') {
+ if (*p == '/')
+ *p = '!';
+ p++;
+ }
+ }
sbi->s_mb_proc = proc_mkdir(devname, proc_root_ext4);
MB_PROC_HANDLER(EXT4_MB_STATS_NAME, stats);
next reply other threads:[~2008-09-05 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 21:06 Alexey Dobriyan [this message]
2008-09-06 7:57 ` [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully Andreas Dilger
2008-09-07 12:15 ` Alexey Dobriyan
2008-09-07 16:04 ` Ralf Hildebrandt
2008-09-07 16:24 ` Theodore Tso
2008-09-07 16:41 ` Alexey Dobriyan
2008-09-08 14:39 ` Theodore Tso
2008-09-09 7:06 ` Alexey Dobriyan
2008-09-09 7:12 ` Andrew Morton
2008-09-09 13:09 ` Theodore Tso
2008-09-09 18:10 ` Andrew Morton
2008-09-09 18:24 ` Theodore Tso
2008-09-09 18:29 ` Andrew Morton
2008-09-09 7:19 ` Alexey Dobriyan
2008-09-09 11:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905210652.GE11569@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-ext4@vger.kernel.org \
--cc=ralf.hildebrandt@charite.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox