From: Alexey Dobriyan <adobriyan@gmail.com>
To: Theodore Tso <tytso@MIT.EDU>
Cc: Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>,
Andreas Dilger <adilger@sun.com>,
akpm@osdl.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully
Date: Tue, 9 Sep 2008 11:19:55 +0400 [thread overview]
Message-ID: <20080909071955.GA5891@x200.localdomain> (raw)
In-Reply-To: <20080908143951.GH8161@mit.edu>
On Mon, Sep 08, 2008 at 10:39:51AM -0400, Theodore Tso wrote:
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2785,14 +2785,19 @@ static int ext4_mb_init_per_dev_proc(struct super_block *sb)
> mode_t mode = S_IFREG | S_IRUGO | S_IWUSR;
> struct ext4_sb_info *sbi = EXT4_SB(sb);
> struct proc_dir_entry *proc;
> - char devname[64];
> + char devname[64], *p;
>
> if (proc_root_ext4 == NULL) {
> sbi->s_mb_proc = NULL;
> return -EINVAL;
> }
> bdevname(sb->s_bdev, devname);
> + while (p = strchr(p, '/'))
> + *p = '!';
This can't work because "p" is uninitialized. And gcc whines about one
more pair of ().
next prev parent reply other threads:[~2008-09-09 7:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 21:06 [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully Alexey Dobriyan
2008-09-06 7:57 ` Andreas Dilger
2008-09-07 12:15 ` Alexey Dobriyan
2008-09-07 16:04 ` Ralf Hildebrandt
2008-09-07 16:24 ` Theodore Tso
2008-09-07 16:41 ` Alexey Dobriyan
2008-09-08 14:39 ` Theodore Tso
2008-09-09 7:06 ` Alexey Dobriyan
2008-09-09 7:12 ` Andrew Morton
2008-09-09 13:09 ` Theodore Tso
2008-09-09 18:10 ` Andrew Morton
2008-09-09 18:24 ` Theodore Tso
2008-09-09 18:29 ` Andrew Morton
2008-09-09 7:19 ` Alexey Dobriyan [this message]
2008-09-09 11:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909071955.GA5891@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=Ralf.Hildebrandt@charite.de \
--cc=adilger@sun.com \
--cc=akpm@osdl.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox