From: Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andreas Dilger <adilger@sun.com>,
akpm@osdl.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully
Date: Sun, 7 Sep 2008 18:04:14 +0200 [thread overview]
Message-ID: <20080907160414.GB26248@charite.de> (raw)
In-Reply-To: <20080907121557.GA3432@x200.localdomain>
* Alexey Dobriyan <adobriyan@gmail.com>:
> > Why not use strchr(), which is normally optimized assembly:
> >
> > char *p = devname;
> > while ((p = strchr(p, '/'))
> > *p = '_';
> >
> > Using '!' as the separator makes it harder to use from shells I suspect,
> > so I'd suggest '_' instead.
>
> bdevname is only 32 bytes and done once per mount, so nobody cares.
>
> '!' is what other code does in this situation (reiserfs, md, ...).
Anyway, the first patch fixes the issue. Will it go into mainline soon?
--
Ralf Hildebrandt (i.A. des IT-Zentrums) Ralf.Hildebrandt@charite.de
Charite - Universitätsmedizin Berlin Tel. +49 (0)30-450 570-155
Gemeinsame Einrichtung von FU- und HU-Berlin Fax. +49 (0)30-450 570-962
IT-Zentrum Standort CBF I'm looking for a job!
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-09-07 16:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 21:06 [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully Alexey Dobriyan
2008-09-06 7:57 ` Andreas Dilger
2008-09-07 12:15 ` Alexey Dobriyan
2008-09-07 16:04 ` Ralf Hildebrandt [this message]
2008-09-07 16:24 ` Theodore Tso
2008-09-07 16:41 ` Alexey Dobriyan
2008-09-08 14:39 ` Theodore Tso
2008-09-09 7:06 ` Alexey Dobriyan
2008-09-09 7:12 ` Andrew Morton
2008-09-09 13:09 ` Theodore Tso
2008-09-09 18:10 ` Andrew Morton
2008-09-09 18:24 ` Theodore Tso
2008-09-09 18:29 ` Andrew Morton
2008-09-09 7:19 ` Alexey Dobriyan
2008-09-09 11:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080907160414.GB26248@charite.de \
--to=ralf.hildebrandt@charite.de \
--cc=adilger@sun.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox