* [PATCH][next] ext2: remove unused pointer bdi
@ 2022-02-07 13:40 Colin Ian King
2022-02-07 14:46 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2022-02-07 13:40 UTC (permalink / raw)
To: Jan Kara, Stephen Rothwell, Andrew Morton, NeilBrown, linux-ext4
Cc: kernel-janitors, linux-kernel
The call to bdi_congested has been removed and so the bdi pointer
is no longer required. Remove it.
Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/ext2/ialloc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index d632764da240..998dd2ac8008 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
unsigned long offset;
unsigned long block;
struct ext2_group_desc * gdp;
- struct backing_dev_info *bdi;
-
- bdi = inode_to_bdi(inode);
block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] ext2: remove unused pointer bdi
2022-02-07 13:40 [PATCH][next] ext2: remove unused pointer bdi Colin Ian King
@ 2022-02-07 14:46 ` Jan Kara
2022-02-07 20:52 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2022-02-07 14:46 UTC (permalink / raw)
To: Colin Ian King
Cc: Jan Kara, Stephen Rothwell, Andrew Morton, NeilBrown, linux-ext4,
kernel-janitors, linux-kernel
On Mon 07-02-22 13:40:39, Colin Ian King wrote:
> The call to bdi_congested has been removed and so the bdi pointer
> is no longer required. Remove it.
>
> Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
I guess this change is in mm tree? So probably it is best if Andrew picks
it up.
Honza
> ---
> fs/ext2/ialloc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index d632764da240..998dd2ac8008 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
> unsigned long offset;
> unsigned long block;
> struct ext2_group_desc * gdp;
> - struct backing_dev_info *bdi;
> -
> - bdi = inode_to_bdi(inode);
>
> block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
> gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
> --
> 2.34.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] ext2: remove unused pointer bdi
2022-02-07 14:46 ` Jan Kara
@ 2022-02-07 20:52 ` NeilBrown
0 siblings, 0 replies; 3+ messages in thread
From: NeilBrown @ 2022-02-07 20:52 UTC (permalink / raw)
To: Jan Kara
Cc: Colin Ian King, Jan Kara, Stephen Rothwell, Andrew Morton,
linux-ext4, kernel-janitors, linux-kernel
On Tue, 08 Feb 2022, Jan Kara wrote:
> On Mon 07-02-22 13:40:39, Colin Ian King wrote:
> > The call to bdi_congested has been removed and so the bdi pointer
> > is no longer required. Remove it.
> >
> > Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> I guess this change is in mm tree? So probably it is best if Andrew picks
> it up.
I have to refresh the whole series - hopefully later this week. I'll
make sure to fix this bit.
Thanks,
NeilBrown
>
> Honza
>
> > ---
> > fs/ext2/ialloc.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> > index d632764da240..998dd2ac8008 100644
> > --- a/fs/ext2/ialloc.c
> > +++ b/fs/ext2/ialloc.c
> > @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
> > unsigned long offset;
> > unsigned long block;
> > struct ext2_group_desc * gdp;
> > - struct backing_dev_info *bdi;
> > -
> > - bdi = inode_to_bdi(inode);
> >
> > block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
> > gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
> > --
> > 2.34.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-07 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-07 13:40 [PATCH][next] ext2: remove unused pointer bdi Colin Ian King
2022-02-07 14:46 ` Jan Kara
2022-02-07 20:52 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox