From: Baokun Li <libaokun1@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jack@suse.cz>,
<ritesh.list@gmail.com>, <linux-kernel@vger.kernel.org>,
<yi.zhang@huawei.com>, <yangerkun@huawei.com>,
<yukuai3@huawei.com>, <libaokun1@huawei.com>
Subject: [PATCH v2 2/8] ext4: do not trim the group with corrupted block bitmap
Date: Thu, 21 Dec 2023 23:05:52 +0800 [thread overview]
Message-ID: <20231221150558.2740823-3-libaokun1@huawei.com> (raw)
In-Reply-To: <20231221150558.2740823-1-libaokun1@huawei.com>
Otherwise operating on an incorrupted block bitmap can lead to all sorts
of unknown problems.
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/mballoc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index d72b5e3c92ec..a95fa6e2b0f9 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6757,6 +6757,9 @@ __releases(ext4_group_lock_ptr(sb, e4b->bd_group))
bool set_trimmed = false;
void *bitmap;
+ if (unlikely(EXT4_MB_GRP_BBITMAP_CORRUPT(e4b->bd_info)))
+ return 0;
+
bitmap = e4b->bd_bitmap;
if (start == 0 && max >= ext4_last_grp_cluster(sb, e4b->bd_group))
set_trimmed = true;
--
2.31.1
next prev parent reply other threads:[~2023-12-21 15:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 15:05 [PATCH v2 0/8] ext4: fix divide error in mb_update_avg_fragment_size() Baokun Li
2023-12-21 15:05 ` [PATCH v2 1/8] ext4: fix double-free of blocks due to wrong extents moved_len Baokun Li
2024-01-04 10:27 ` Jan Kara
2023-12-21 15:05 ` Baokun Li [this message]
2023-12-21 15:05 ` [PATCH v2 3/8] ext4: regenerate buddy after block freeing failed if under fc replay Baokun Li
2024-01-04 10:33 ` Jan Kara
2024-01-04 11:31 ` Baokun Li
2023-12-21 15:05 ` [PATCH v2 4/8] ext4: avoid bb_free and bb_fragments inconsistency in mb_free_blocks() Baokun Li
2024-01-04 10:42 ` Jan Kara
2024-01-04 11:43 ` Baokun Li
2023-12-21 15:05 ` [PATCH v2 5/8] ext4: avoid dividing by 0 in mb_update_avg_fragment_size() when block bitmap corrupt Baokun Li
2024-01-04 10:43 ` Jan Kara
2023-12-21 15:05 ` [PATCH v2 6/8] ext4: avoid allocating blocks from corrupted group in ext4_mb_try_best_found() Baokun Li
2024-01-04 10:45 ` Jan Kara
2023-12-21 15:05 ` [PATCH v2 7/8] ext4: avoid allocating blocks from corrupted group in ext4_mb_find_by_goal() Baokun Li
2024-01-04 10:47 ` Jan Kara
2023-12-21 15:05 ` [PATCH v2 8/8] ext4: mark the group block bitmap as corrupted before reporting an error Baokun Li
2024-01-04 10:51 ` Jan Kara
2024-01-04 12:14 ` Baokun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221150558.2740823-3-libaokun1@huawei.com \
--to=libaokun1@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox