public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Vegard Nossum <vegard.nossum@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: ext4: fix reference counting bug on block allocation error
Date: Sun, 14 Aug 2016 20:37:56 +0200	[thread overview]
Message-ID: <57B0BA84.1000600@oracle.com> (raw)
In-Reply-To: <20160814183206.GA11040@kroah.com>

On 08/14/2016 08:32 PM, Greg KH wrote:
> Hi Vegard and ext4 developers,
>
> The patch below, in Linus's tree, references a patch in the Fixes: line
> that is not in Linus's tree (neither the git commit id, nor the subject
> line.)
>

It seems to exist?

 >> Fixes: 8556e8f3b6 ("ext4: Don't allow new groups to be added during 
block allocation")

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8556e8f3b6c4c11601ce1e9ea8090a6d8bd5daae

> That's a bit confusing, what is this patch supposed to be fixing up?
> What stable tree(s) should it go to if the original patch it fixes isn't
> even in any tree?

The referenced commit adds the ext4_mb_release_context(ac); line which
is what is causing problems because that releases the context which is
still in fact in use.

>
> confused,

Confused too :-)


Vegard

  reply	other threads:[~2016-08-14 18:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160727052921.5B41C35574@git2.kroah.org>
2016-08-14 18:32 ` ext4: fix reference counting bug on block allocation error Greg KH
2016-08-14 18:37   ` Vegard Nossum [this message]
2016-08-14 18:51     ` Greg KH
2016-08-14 18:58       ` Greg KH
2016-08-14 19:02         ` Vegard Nossum
2016-08-14 19:09           ` Greg KH
2016-08-14 19:35             ` Vegard Nossum
2016-08-14 19:46               ` Greg KH
2016-08-14 20:19             ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57B0BA84.1000600@oracle.com \
    --to=vegard.nossum@oracle.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox