* Using tgid instead of pid in ext3_find_near()
@ 2008-04-28 19:07 Manish Katiyar
2008-04-29 0:57 ` Mulyadi Santosa
0 siblings, 1 reply; 3+ messages in thread
From: Manish Katiyar @ 2008-04-28 19:07 UTC (permalink / raw)
To: Kernel Newbies, linux-ext4
Hi,
In the function ext*_find_near() we are using pid to have the locality
of the blocks for the files which have same functionality. Shouldn't
we be using "current->tgid" here instead ??
410 static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind)
411 {
.........
........
433 colour = (current->pid % 16) *
434 (EXT3_BLOCKS_PER_GROUP(inode->i_sb) / 16);
........
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Using tgid instead of pid in ext3_find_near()
2008-04-28 19:07 Using tgid instead of pid in ext3_find_near() Manish Katiyar
@ 2008-04-29 0:57 ` Mulyadi Santosa
2008-04-29 4:23 ` Manish Katiyar
0 siblings, 1 reply; 3+ messages in thread
From: Mulyadi Santosa @ 2008-04-29 0:57 UTC (permalink / raw)
To: Manish Katiyar; +Cc: Kernel Newbies, linux-ext4
Ehmmm....
On Tue, Apr 29, 2008 at 2:07 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> Hi,
>
> In the function ext*_find_near() we are using pid to have the locality
> of the blocks for the files which have same functionality. Shouldn't
> we be using "current->tgid" here instead ??
>
> 410 static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind)
> 411 {
> .........
> ........
> 433 colour = (current->pid % 16) *
> 434 (EXT3_BLOCKS_PER_GROUP(inode->i_sb) / 16);
> ........
Because each threads even on same thread group doesn't need to share
open file descriptors?
regards,
Mulyadi.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Using tgid instead of pid in ext3_find_near()
2008-04-29 0:57 ` Mulyadi Santosa
@ 2008-04-29 4:23 ` Manish Katiyar
0 siblings, 0 replies; 3+ messages in thread
From: Manish Katiyar @ 2008-04-29 4:23 UTC (permalink / raw)
To: Mulyadi Santosa; +Cc: Kernel Newbies, linux-ext4
On Tue, Apr 29, 2008 at 6:27 AM, Mulyadi Santosa
<mulyadi.santosa@gmail.com> wrote:
> Ehmmm....
>
>
> On Tue, Apr 29, 2008 at 2:07 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> > Hi,
> >
> > In the function ext*_find_near() we are using pid to have the locality
> > of the blocks for the files which have same functionality. Shouldn't
> > we be using "current->tgid" here instead ??
> >
> > 410 static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind)
> > 411 {
> > .........
> > ........
> > 433 colour = (current->pid % 16) *
> > 434 (EXT3_BLOCKS_PER_GROUP(inode->i_sb) / 16);
> > ........
>
> Because each threads even on same thread group doesn't need to share
> open file descriptors?
Hi Mulyadi,
It's not about the open file descriptors. The idea behind putting this
is to put all the blocks of same process (which may be functionally
related) nearby in the blockgroup for locality. So I think we should
be using tgid instead of pid.
Thanks
>
> regards,
>
> Mulyadi.
>
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-29 4:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-28 19:07 Using tgid instead of pid in ext3_find_near() Manish Katiyar
2008-04-29 0:57 ` Mulyadi Santosa
2008-04-29 4:23 ` Manish Katiyar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox