From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] radeonfb: prevent spurious recompilations
Date: Wed, 12 Oct 2005 06:59:02 +1000 [thread overview]
Message-ID: <1129064342.17365.213.camel@gaston> (raw)
In-Reply-To: <20051011215507.64e8aa40.khali@linux-fr.org>
On Tue, 2005-10-11 at 21:55 +0200, Jean Delvare wrote:
> Hi Ben, all,
>
> I'm doing frequent changes to the i2c header files, and noticed that
> the radeonfb driver was recompiled each time I do, although I did not
> include the I2C/DDC support. This is due to i2c header files being
> included when they are not needed. Here is a patch fixing the problem.
> Please consider applying it.
I generally quite dislike such #ifdef clutter ...
Ben.
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
next prev parent reply other threads:[~2005-10-11 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-11 19:55 [PATCH] radeonfb: prevent spurious recompilations Jean Delvare
2005-10-11 20:59 ` Benjamin Herrenschmidt [this message]
2005-10-12 8:31 ` Jean Delvare
2005-10-12 10:29 ` Benjamin Herrenschmidt
2005-10-12 10:36 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129064342.17365.213.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=khali@linux-fr.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox