From: "Jean Delvare" <khali@linux-fr.org>
To: benh@kernel.crashing.org
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] radeonfb: prevent spurious recompilations
Date: Wed, 12 Oct 2005 10:31:54 +0200 (CEST) [thread overview]
Message-ID: <q2tzm25j.1129105914.0394050.khali@localhost> (raw)
In-Reply-To: <1129064342.17365.213.camel@gaston>
Hi Ben,
On 2005-10-11 Jean Delvare wrote:
> > I'm doing frequent changes to the i2c header files, and noticed that
> > the radeonfb driver was recompiled each time I do, although I did not
> > include the I2C/DDC support. This is due to i2c header files being
> > included when they are not needed. Here is a patch fixing the problem.
> > Please consider applying it.
On 2005-10-11, Benjamin Herrenschmidt wrote:
> I generally quite dislike such #ifdef clutter ...
#ifdef CONFIG_FB_RADEON_I2C is already used 12 times in the radeonfb
driver, I don't think one more time will really make a difference.
Or do you have a different fix for my problem, that you would prefer?
Thanks,
--
Jean Delvare
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
next prev parent reply other threads:[~2005-10-12 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-11 19:55 [PATCH] radeonfb: prevent spurious recompilations Jean Delvare
2005-10-11 20:59 ` Benjamin Herrenschmidt
2005-10-12 8:31 ` Jean Delvare [this message]
2005-10-12 10:29 ` Benjamin Herrenschmidt
2005-10-12 10:36 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2tzm25j.1129105914.0394050.khali@localhost \
--to=khali@linux-fr.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox