From: Jean Delvare <khali@linux-fr.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] radeonfb: prevent spurious recompilations
Date: Tue, 11 Oct 2005 21:55:07 +0200 [thread overview]
Message-ID: <20051011215507.64e8aa40.khali@linux-fr.org> (raw)
Hi Ben, all,
I'm doing frequent changes to the i2c header files, and noticed that
the radeonfb driver was recompiled each time I do, although I did not
include the I2C/DDC support. This is due to i2c header files being
included when they are not needed. Here is a patch fixing the problem.
Please consider applying it.
Thanks.
Prevent spurious recompilations of the radeonfb driver when I2C/DDC
support is not included and i2c header files are modified.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/video/aty/radeon_base.c | 1 -
drivers/video/aty/radeonfb.h | 3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.14-rc4.orig/drivers/video/aty/radeon_base.c 2005-10-11 21:37:22.000000000 +0200
+++ linux-2.6.14-rc4/drivers/video/aty/radeon_base.c 2005-10-11 21:37:44.000000000 +0200
@@ -69,7 +69,6 @@
#include <linux/pci.h>
#include <linux/vmalloc.h>
#include <linux/device.h>
-#include <linux/i2c.h>
#include <asm/io.h>
#include <asm/uaccess.h>
--- linux-2.6.14-rc4.orig/drivers/video/aty/radeonfb.h 2005-10-01 11:01:06.000000000 +0200
+++ linux-2.6.14-rc4/drivers/video/aty/radeonfb.h 2005-10-11 21:41:46.000000000 +0200
@@ -10,9 +10,10 @@
#include <linux/fb.h>
+#ifdef CONFIG_FB_RADEON_I2C
#include <linux/i2c.h>
-#include <linux/i2c-id.h>
#include <linux/i2c-algo-bit.h>
+#endif
#include <asm/io.h>
--
Jean Delvare
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
next reply other threads:[~2005-10-11 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-11 19:55 Jean Delvare [this message]
2005-10-11 20:59 ` [PATCH] radeonfb: prevent spurious recompilations Benjamin Herrenschmidt
2005-10-12 8:31 ` Jean Delvare
2005-10-12 10:29 ` Benjamin Herrenschmidt
2005-10-12 10:36 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051011215507.64e8aa40.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox