[PATCH] radeonfb: prevent spurious recompilations

[PATCH] radeonfb: prevent spurious recompilations

[Jean Delvare]

Hi Ben, all,

I'm doing frequent changes to the i2c header files, and noticed that
the radeonfb driver was recompiled each time I do, although I did not
include the I2C/DDC support. This is due to i2c header files being
included when they are not needed. Here is a patch fixing the problem.
Please consider applying it.

Thanks.


Prevent spurious recompilations of the radeonfb driver when I2C/DDC
support is not included and i2c header files are modified.

Signed-off-by: Jean Delvare <khali@linux-fr.org>

 drivers/video/aty/radeon_base.c |    1 -
 drivers/video/aty/radeonfb.h    |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.14-rc4.orig/drivers/video/aty/radeon_base.c	2005-10-11 21:37:22.000000000 +0200
+++ linux-2.6.14-rc4/drivers/video/aty/radeon_base.c	2005-10-11 21:37:44.000000000 +0200
@@ -69,7 +69,6 @@
 #include <linux/pci.h>
 #include <linux/vmalloc.h>
 #include <linux/device.h>
-#include <linux/i2c.h>
 
 #include <asm/io.h>
 #include <asm/uaccess.h>
--- linux-2.6.14-rc4.orig/drivers/video/aty/radeonfb.h	2005-10-01 11:01:06.000000000 +0200
+++ linux-2.6.14-rc4/drivers/video/aty/radeonfb.h	2005-10-11 21:41:46.000000000 +0200
@@ -10,9 +10,10 @@
 #include <linux/fb.h>
 
 
+#ifdef CONFIG_FB_RADEON_I2C
 #include <linux/i2c.h>
-#include <linux/i2c-id.h>
 #include <linux/i2c-algo-bit.h>
+#endif
 
 #include <asm/io.h>
 


-- 
Jean Delvare


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: [PATCH] radeonfb: prevent spurious recompilations

[Benjamin Herrenschmidt]

On Tue, 2005-10-11 at 21:55 +0200, Jean Delvare wrote:
> Hi Ben, all,
> 
> I'm doing frequent changes to the i2c header files, and noticed that
> the radeonfb driver was recompiled each time I do, although I did not
> include the I2C/DDC support. This is due to i2c header files being
> included when they are not needed. Here is a patch fixing the problem.
> Please consider applying it.

I generally quite dislike such #ifdef clutter ... 

Ben.




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: [PATCH] radeonfb: prevent spurious recompilations

[Jean Delvare]

Hi Ben,

On 2005-10-11 Jean Delvare wrote:
> > I'm doing frequent changes to the i2c header files, and noticed that
> > the radeonfb driver was recompiled each time I do, although I did not
> > include the I2C/DDC support. This is due to i2c header files being
> > included when they are not needed. Here is a patch fixing the problem.
> > Please consider applying it.

On 2005-10-11, Benjamin Herrenschmidt wrote:
> I generally quite dislike such #ifdef clutter ...

#ifdef CONFIG_FB_RADEON_I2C is already used 12 times in the radeonfb
driver, I don't think one more time will really make a difference.

Or do you have a different fix for my problem, that you would prefer?

Thanks,
--
Jean Delvare


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: [PATCH] radeonfb: prevent spurious recompilations

[Benjamin Herrenschmidt]

> #ifdef CONFIG_FB_RADEON_I2C is already used 12 times in the radeonfb
> driver, I don't think one more time will really make a difference.

Yah, that sucks, I should fix that

> Or do you have a different fix for my problem, that you would prefer?

Nah, just submit that patch for now, I'll do a better fix later

Ben.




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: [PATCH] radeonfb: prevent spurious recompilations

[Jean Delvare]

Hi Ben,

On 2005-10-12, Benjamin Herrenschmidt wrote:
> Nah, just submit that patch for now, I'll do a better fix later

Submit to whom? I thought you were the right person (and the
linux-fbdev-devel list the right place) to submit it to.

Thanks,
--
Jean Delvare


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl