* [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally
@ 2026-08-14 18:42 Randy Dunlap
2026-08-14 19:40 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-08-14 18:42 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Helge Deller, linux-fbdev, dri-devel,
Maciej W. Rozycki
This driver cannot be built as a loadable module so testing for
"#ifdef MODULE" is not appropriate here.
Also, MODULE_LICENSE() is always available.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
drivers/video/fbdev/maxinefb.c | 2 --
1 file changed, 2 deletions(-)
--- linux-next-20260814.orig/drivers/video/fbdev/maxinefb.c
+++ linux-next-20260814/drivers/video/fbdev/maxinefb.c
@@ -169,9 +169,7 @@ static void __exit maxinefb_exit(void)
unregister_framebuffer(&fb_info);
}
-#ifdef MODULE
MODULE_LICENSE("GPL");
-#endif
module_init(maxinefb_init);
module_exit(maxinefb_exit);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally
2026-08-14 18:42 [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally Randy Dunlap
@ 2026-08-14 19:40 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2026-08-14 19:40 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel; +Cc: linux-fbdev, dri-devel, Maciej W. Rozycki
On 8/14/26 20:42, Randy Dunlap wrote:
> This driver cannot be built as a loadable module so testing for
> "#ifdef MODULE" is not appropriate here.
> Also, MODULE_LICENSE() is always available.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
>
> drivers/video/fbdev/maxinefb.c | 2 --
> 1 file changed, 2 deletions(-)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-14 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-14 18:42 [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally Randy Dunlap
2026-08-14 19:40 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox