* [PATCH] fbdev: omapfb: fix some error codes
@ 2023-10-16 11:19 Dan Carpenter
2023-10-16 21:09 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-10-16 11:19 UTC (permalink / raw)
To: Helge Deller
Cc: Thomas Zimmermann, Sam Ravnborg, Uwe Kleine-König, Yang Yang,
Xu Panda, Lucy Mielke, linux-fbdev, linux-omap, dri-devel,
kernel-janitors
Return negative -ENXIO instead of positive ENXIO.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
No fixes tag because the caller doesn't check for errors.
drivers/video/fbdev/omap/omapfb_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index f28cb90947a3..42c96f1cfc93 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1645,13 +1645,13 @@ static int omapfb_do_probe(struct platform_device *pdev,
}
fbdev->int_irq = platform_get_irq(pdev, 0);
if (fbdev->int_irq < 0) {
- r = ENXIO;
+ r = -ENXIO;
goto cleanup;
}
fbdev->ext_irq = platform_get_irq(pdev, 1);
if (fbdev->ext_irq < 0) {
- r = ENXIO;
+ r = -ENXIO;
goto cleanup;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fbdev: omapfb: fix some error codes
2023-10-16 11:19 [PATCH] fbdev: omapfb: fix some error codes Dan Carpenter
@ 2023-10-16 21:09 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2023-10-16 21:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Thomas Zimmermann, Sam Ravnborg, Uwe Kleine-König, Yang Yang,
Xu Panda, Lucy Mielke, linux-fbdev, linux-omap, dri-devel,
kernel-janitors
On 10/16/23 13:19, Dan Carpenter wrote:
> Return negative -ENXIO instead of positive ENXIO.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
applied.
Thanks!
Helge
> ---
> No fixes tag because the caller doesn't check for errors.
>
> drivers/video/fbdev/omap/omapfb_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index f28cb90947a3..42c96f1cfc93 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1645,13 +1645,13 @@ static int omapfb_do_probe(struct platform_device *pdev,
> }
> fbdev->int_irq = platform_get_irq(pdev, 0);
> if (fbdev->int_irq < 0) {
> - r = ENXIO;
> + r = -ENXIO;
> goto cleanup;
> }
>
> fbdev->ext_irq = platform_get_irq(pdev, 1);
> if (fbdev->ext_irq < 0) {
> - r = ENXIO;
> + r = -ENXIO;
> goto cleanup;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-16 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 11:19 [PATCH] fbdev: omapfb: fix some error codes Dan Carpenter
2023-10-16 21:09 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox